From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751547AbdISIUd (ORCPT ); Tue, 19 Sep 2017 04:20:33 -0400 Received: from mail.free-electrons.com ([62.4.15.54]:57554 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751057AbdISIUb (ORCPT ); Tue, 19 Sep 2017 04:20:31 -0400 Date: Tue, 19 Sep 2017 10:20:19 +0200 From: Maxime Ripard To: Icenowy Zheng Cc: Srinivas Kandagatla , Chen-Yu Tsai , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com Subject: Re: [PATCH] nvmem: sunxi-sid: add support for A64/H5's SID controller Message-ID: <20170919082019.6bopwauso4mbslqo@flea.lan> References: <20170918154204.54427-1-icenowy@aosc.io> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="whqjkw4wpkjzhnli" Content-Disposition: inline In-Reply-To: <20170918154204.54427-1-icenowy@aosc.io> User-Agent: NeoMutt/20170714 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --whqjkw4wpkjzhnli Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Sep 18, 2017 at 11:42:04PM +0800, Icenowy Zheng wrote: > Allwinner A64/H5 SoCs come with a SID controller like the one in H3, but > without the silicon bug that makes the initial value at 0x200 wrong, so > the value at 0x200 can be directly read. >=20 > Add support for this kind of SID controller. >=20 > Signed-off-by: Icenowy Zheng > --- > Documentation/devicetree/bindings/nvmem/allwinner,sunxi-sid.txt | 1 + > drivers/nvmem/sunxi_sid.c | 6 ++++= ++ > 2 files changed, 7 insertions(+) >=20 > diff --git a/Documentation/devicetree/bindings/nvmem/allwinner,sunxi-sid.= txt b/Documentation/devicetree/bindings/nvmem/allwinner,sunxi-sid.txt > index ef06d061913c..6ea0836939ee 100644 > --- a/Documentation/devicetree/bindings/nvmem/allwinner,sunxi-sid.txt > +++ b/Documentation/devicetree/bindings/nvmem/allwinner,sunxi-sid.txt > @@ -5,6 +5,7 @@ Required properties: > "allwinner,sun4i-a10-sid" > "allwinner,sun7i-a20-sid" > "allwinner,sun8i-h3-sid" > + "allwinner,sun50i-a64-sid" > =20 > - reg: Should contain registers location and length > =20 > diff --git a/drivers/nvmem/sunxi_sid.c b/drivers/nvmem/sunxi_sid.c > index 0d6648be93b8..3c9fd4fb9207 100644 > --- a/drivers/nvmem/sunxi_sid.c > +++ b/drivers/nvmem/sunxi_sid.c > @@ -199,10 +199,16 @@ static const struct sunxi_sid_cfg sun8i_h3_cfg =3D { > .need_register_readout =3D true, > }; > =20 > +static const struct sunxi_sid_cfg sun50i_a64_cfg =3D { > + .value_offset =3D 0x200, > + .size =3D 0x100, > +}; > + How did you get those values? Also, it's reported that the SID can only be accessed in secure mode, did you test it? Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com --whqjkw4wpkjzhnli Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIcBAEBAgAGBQJZwNNDAAoJEBx+YmzsjxAgoHUP/jsSEdJdKXdGMRiq4/VrnvbH IV+6b23YfPNiiUkV54HU8Xue3GFLw8VUynl39GAz2UvC6BjIqs/KdjGPWeYasQ2n Hf6z+9T7DOIgqs+NvAG5yXV7LiJNEhyTf4sRsWfDDiPzczuqwLVWAX6KZshcUJVZ xAq5i6QHvb0WX2th0/WTwWRqnh/GQA/uclRqa/mUzYR3wi8hzxL3MF0ZNU5+RX2U ty23BJ5PTrThAi6QcqZS7IAxaxpN1p6Lan6ZPBPn1U3YghS/Mx+vUW5NM65BNBYo AOzkPfCXLIaLFXAQHfWNlkbIPeZN8ErBvzAxPESLDyYCgEuJsyX3TFOCO9aj6cAC fCH7xeyOituTb6/j73HPEiT33HqQkp4fxXvdGZzAUKWI296Ff6jk9NBNFNVWeTgt n3GrXPUc6ZmeQZfPnNxS7LAYgF43frb8vjARpnewZuPxecfJ4go2BNw6XMPpSO0j fUh0NAmGVKD+aMDPO8XKeDU2yyN+6Vnt1gxWqqAFhqHQgR1xBWCoPowUEIEBQTQp st+j65sVw9vrRpiPEiEaq/MRXh8blG/GhIiHS+9mgj+qWY5f+JVocKq8uKATXOat Cszw5mGxbAjISMAjwhqHipMo9YdqPNw+3CoOmIY6o0+seyIOWBMzSRv4YE/wmnmB AcP6vwut9xjk0UgCTqGp =oJp5 -----END PGP SIGNATURE----- --whqjkw4wpkjzhnli--