From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751854AbdISMju (ORCPT <rfc822;w@1wt.eu>);
        Tue, 19 Sep 2017 08:39:50 -0400
Received: from mail.linuxfoundation.org ([140.211.169.12]:37950 "EHLO
        mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751000AbdISMjt (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 19 Sep 2017 08:39:49 -0400
Date: Tue, 19 Sep 2017 14:39:59 +0200
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Andrey Konovalov <andreyknvl@google.com>
Cc: Jaejoong Kim <climbbb.kim@gmail.com>, Jonathan Corbet <corbet@lwn.net>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        USB list <linux-usb@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        syzkaller <syzkaller@googlegroups.com>,
        Kostya Serebryany <kcc@google.com>, Dmitry Vyukov <dvyukov@google.com>
Subject: Re: usb/core: slab-out-of-bounds in usb_set_configuration
Message-ID: <20170919123959.GB17917@kroah.com>
References: <CAAeHK+ygpdT9kAQyF7qjaNwQ5jV85=6AyycY91LA=pYRLm91RQ@mail.gmail.com>
 <20170918185039.GB32669@kroah.com>
 <CAAeHK+wPeVif+cE0EnQsaadv5FsTYDMTPzwXAnHPuy_dyNGAQA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAAeHK+wPeVif+cE0EnQsaadv5FsTYDMTPzwXAnHPuy_dyNGAQA@mail.gmail.com>
User-Agent: Mutt/1.9.0 (2017-09-02)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Sep 19, 2017 at 01:54:57PM +0200, Andrey Konovalov wrote:
> On Mon, Sep 18, 2017 at 8:50 PM, Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
> > On Mon, Sep 18, 2017 at 07:22:24PM +0200, Andrey Konovalov wrote:
> >> Hi!
> >>
> >> I've got the following crash while fuzzing the kernel with syzkaller.
> >>
> >> On commit ebb2c2437d8008d46796902ff390653822af6cc4 (Sep 18).
> >>
> >> It seems there's no proper size check of a
> >> USB_DT_INTERFACE_ASSOCIATION descriptor. It's only checked that the
> >> size is >= 2 in usb_parse_configuration(), so find_iad() might do
> >> out-of-bounds access to intf_assoc->bInterfaceCount.
> >
> > Ah, nice catch!
> >
> > Does the patch below fix this?
> 
> Hi Greg,
> 
> I believe it does and the bug is no longer triggered with the
> reproducer that I have.
> 
> Tested-by: Andrey Konovalov <andreyknvl@google.com>

Thanks for testing, I'll go queue this up.

greg k-h