From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751544AbdISV63 (ORCPT ); Tue, 19 Sep 2017 17:58:29 -0400 Received: from mail.kernel.org ([198.145.29.99]:56036 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751074AbdISV61 (ORCPT ); Tue, 19 Sep 2017 17:58:27 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 93E5021456 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=rostedt@goodmis.org Date: Tue, 19 Sep 2017 17:58:23 -0400 From: Steven Rostedt To: Christoph Hellwig Cc: Waiman Long , Jens Axboe , Ingo Molnar , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-nilfs@vger.kernel.org, cluster-devel@redhat.com, Bart Van Assche Subject: Re: [PATCH v6 1/2] blktrace: Fix potentail deadlock between delete & sysfs ops Message-ID: <20170919175823.51e3413d@gandalf.local.home> In-Reply-To: <20170919204135.GA7411@infradead.org> References: <1505760831-7747-1-git-send-email-longman@redhat.com> <1505760831-7747-2-git-send-email-longman@redhat.com> <20170919000155.GA30806@infradead.org> <20170919143811.GB15944@infradead.org> <20170919204135.GA7411@infradead.org> X-Mailer: Claws Mail 3.14.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 19 Sep 2017 13:41:35 -0700 Christoph Hellwig wrote: > Call it blk_trace mutex and move it right next to the blk_trace > structure: > > ifdef CONFIG_BLK_DEV_IO_TRACE > struct blk_trace *blk_trace; > struct mutex blk_trace_mutex; > #endif > > which makes it completely obvious to any read what you are protecting > with it. As a 1000ft away bystander, this appears to be the most logical solution. -- Steve