From: Bjorn Helgaas <helgaas@kernel.org>
To: Bhumika Goyal <bhumirks@gmail.com>
Cc: julia.lawall@lip6.fr, bhelgaas@google.com, tglx@linutronix.de,
mingo@redhat.com, hpa@zytor.com, x86@kernel.org,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86/pci/intel_mid_pci: make intel_mid_pci_ops const and __initconst
Date: Tue, 19 Sep 2017 14:45:32 -0500 [thread overview]
Message-ID: <20170919194532.GG22312@bhelgaas-glaptop.roam.corp.google.com> (raw)
In-Reply-To: <1505751895-9799-1-git-send-email-bhumirks@gmail.com>
On Mon, Sep 18, 2017 at 09:54:55PM +0530, Bhumika Goyal wrote:
> Make this const as it is only used during a copy operation. This usage
> is inside init function and the structure is not referenced after
> initialisation, so make it __initconst too.
>
> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
I applied this to pci/misc for v4.15, thanks!
If this conflicts with patches going via x86, I'll gladly drop it from my
tree; just let me know.
> ---
> arch/x86/pci/intel_mid_pci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/pci/intel_mid_pci.c b/arch/x86/pci/intel_mid_pci.c
> index b901ece..63fbe8f 100644
> --- a/arch/x86/pci/intel_mid_pci.c
> +++ b/arch/x86/pci/intel_mid_pci.c
> @@ -279,7 +279,7 @@ static void intel_mid_pci_irq_disable(struct pci_dev *dev)
> }
> }
>
> -static struct pci_ops intel_mid_pci_ops = {
> +static const struct pci_ops intel_mid_pci_ops __initconst = {
> .read = pci_read,
> .write = pci_write,
> };
> --
> 1.9.1
>
prev parent reply other threads:[~2017-09-19 19:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-18 16:24 Bhumika Goyal
2017-09-19 19:45 ` Bjorn Helgaas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170919194532.GG22312@bhelgaas-glaptop.roam.corp.google.com \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=bhumirks@gmail.com \
--cc=hpa@zytor.com \
--cc=julia.lawall@lip6.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®