From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751730AbdISXiB (ORCPT ); Tue, 19 Sep 2017 19:38:01 -0400 Received: from mga03.intel.com ([134.134.136.65]:25179 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751688AbdISXh7 (ORCPT ); Tue, 19 Sep 2017 19:37:59 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,419,1500966000"; d="scan'208";a="153297051" From: Miguel Bernal Marin To: Josh Poimboeuf , Peter Zijlstra , Ingo Molnar , Thomas Gleixner , "H . Peter Anvin" Cc: linux-kernel@vger.kernel.org, x86@kernel.org Subject: [PATCH v3 6/6] x86, asm/rwsem: Use named operands in __downgrade_write() Date: Tue, 19 Sep 2017 18:37:45 -0500 Message-Id: <20170919233745.15343-7-miguel.bernal.marin@linux.intel.com> X-Mailer: git-send-email 2.14.1 In-Reply-To: <20170919233745.15343-1-miguel.bernal.marin@linux.intel.com> References: <20170906052613.30058-1-miguel.bernal.marin@linux.intel.com> <20170919233745.15343-1-miguel.bernal.marin@linux.intel.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Since GCC version 3.1, it is possible to specify input and output operands using symbolic names which can be referenced within the assembler code. Convert to named operands makes easy to understand and maintain for future changes. Signed-off-by: Miguel Bernal Marin --- arch/x86/include/asm/rwsem.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/x86/include/asm/rwsem.h b/arch/x86/include/asm/rwsem.h index 3245902e961f..1f5d083599ba 100644 --- a/arch/x86/include/asm/rwsem.h +++ b/arch/x86/include/asm/rwsem.h @@ -208,7 +208,7 @@ static inline void __downgrade_write(struct rw_semaphore *sem) register void *__sp asm(_ASM_SP); asm volatile("# beginning __downgrade_write\n\t" - LOCK_PREFIX _ASM_ADD "%3,(%2)\n\t" + LOCK_PREFIX _ASM_ADD "%[inc],(%[sem])\n\t" /* * transitions 0xZZZZ0001 -> 0xYYYY0001 (i386) * 0xZZZZZZZZ00000001 -> 0xYYYYYYYY00000001 (x86_64) @@ -218,7 +218,7 @@ static inline void __downgrade_write(struct rw_semaphore *sem) "1:\n\t" "# ending __downgrade_write\n" : "+m" (sem->count), "+r" (__sp) - : "a" (sem), "er" (-RWSEM_WAITING_BIAS) + : [sem] "a" (sem), [inc] "er" (-RWSEM_WAITING_BIAS) : "memory", "cc"); } -- 2.14.1