From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751943AbdITMkp (ORCPT ); Wed, 20 Sep 2017 08:40:45 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:48388 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751529AbdITMkm (ORCPT ); Wed, 20 Sep 2017 08:40:42 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 9FB1C60134 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: rsi: fix a dereference on adapter before it has been null checked From: Kalle Valo In-Reply-To: <20170908152452.3594-1-colin.king@canonical.com> References: <20170908152452.3594-1-colin.king@canonical.com> To: Colin Ian King Cc: Amitkumar Karwar , Prameela Rani Garnepudi , Karun Eagalapati , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org User-Agent: pwcli/0.0.0-git (https://github.com/kvalo/pwcli/) Python/2.7.12 Message-Id: <20170920124041.DE3EA60134@smtp.codeaurora.org> Date: Wed, 20 Sep 2017 12:40:41 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Colin Ian King wrote: > From: Colin Ian King > > The assignment of dev is dereferencing adapter before adapter has > been null checked, potentially leading to a null pointer dereference. > Fix this by simply moving the assignment of dev to a later point > after the sanity null check of adapter. > > Detected by CoverityScan CID#1398383 ("Dereference before null check") > > Fixes: dad0d04fa7ba ("rsi: Add RS9113 wireless driver") > Signed-off-by: Colin Ian King Patch applied to wireless-drivers-next.git, thanks. 6508497cbdc7 rsi: fix a dereference on adapter before it has been null checked -- https://patchwork.kernel.org/patch/9944509/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches