From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751683AbdITRzH (ORCPT ); Wed, 20 Sep 2017 13:55:07 -0400 Received: from mail.kernel.org ([198.145.29.99]:34284 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751301AbdITRzH (ORCPT ); Wed, 20 Sep 2017 13:55:07 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 90A6D21A1D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=rostedt@goodmis.org Date: Wed, 20 Sep 2017 13:55:03 -0400 From: Steven Rostedt To: Vitaly Kuznetsov Cc: devel@linuxdriverproject.org, linux-kernel@vger.kernel.org, "K. Y. Srinivasan" , Haiyang Zhang , Stephen Hemminger , Dexuan Cui Subject: Re: [PATCH 02/16] hyper-v: trace vmbus_on_message() Message-ID: <20170920135503.690cd21e@gandalf.local.home> In-Reply-To: <20170920172207.12622-3-vkuznets@redhat.com> References: <20170920172207.12622-1-vkuznets@redhat.com> <20170920172207.12622-3-vkuznets@redhat.com> X-Mailer: Claws Mail 3.14.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 20 Sep 2017 19:21:53 +0200 Vitaly Kuznetsov wrote: > diff --git a/drivers/hv/hv_trace.h b/drivers/hv/hv_trace.h > index 9a29ef55477d..72911dfc9682 100644 > --- a/drivers/hv/hv_trace.h > +++ b/drivers/hv/hv_trace.h > @@ -14,6 +14,14 @@ TRACE_EVENT(vmbus_on_msg_dpc, > TP_printk("message %u received", __entry->msgtype) > ); > > +TRACE_EVENT(vmbus_on_message, > + TP_PROTO(const struct vmbus_channel_message_header *hdr), > + TP_ARGS(hdr), > + TP_STRUCT__entry(__field(unsigned int, msgtype)), > + TP_fast_assign(__entry->msgtype = hdr->msgtype), > + TP_printk("processing message %u", __entry->msgtype) > + ); Whenever you have two trace events with everything the same but the TP_printk(), you can save a little space by using DEFINE_EVENT_PRINT() DECLARE_EVENT_CLASS(vmbus_hdr_msg, TP_PROTO(const struct vmbus_channel_message_header *hdr), TP_ARGS(hdr), TP_STRUCT__entry(__field(unsigned int, msgtype), TP_fast_assign(__entry->msg = hdr->msgtype;), TP_printk("msgtype=%d", __entry->msgtype) ); DEFINE_EVENT_PRINT(vmbus_hdr_msg, vmbus_on_msg_dpc, TP_PROTO(const struct vmbus_channel_message_header *hdr), TP_ARGS(hdr), TP_printk("message %u received", __entry->msgtype)); DEFINE_EVENT_PRINT(vmbus_hdr_msg, vmbus_on_message, TP_PROTO(const struct vmbus_channel_message_header *hdr), TP_ARGS(hdr), TP_printk("processing message %u", __entry->msgtype)); This will use the same functions required to save and record the message but will use a different function to output it to the trace. -- Steve