From: Eric Anholt <eric@anholt.net>
To: dri-devel@lists.freedesktop.org
Cc: linux-kernel@vger.kernel.org, Eric Anholt <eric@anholt.net>,
Boris Brezillon <boris.brezillon@free-electrons.com>,
Hans Verkuil <hverkuil@xs4all.nl>
Subject: [PATCH 2/2] drm/vc4: Update kerneldoc about CEC and power management
Date: Wed, 20 Sep 2017 15:59:35 -0700 [thread overview]
Message-ID: <20170920225935.14566-2-eric@anholt.net> (raw)
In-Reply-To: <20170920225935.14566-1-eric@anholt.net>
Boris had added full power management, and then Hans partially removed
it to enable CEC, so update the docs about both.
Cc: Boris Brezillon <boris.brezillon@free-electrons.com>
Cc: Hans Verkuil <hverkuil@xs4all.nl>
Signed-off-by: Eric Anholt <eric@anholt.net>
---
drivers/gpu/drm/vc4/vc4_hdmi.c | 10 +++-------
1 file changed, 3 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/vc4/vc4_hdmi.c b/drivers/gpu/drm/vc4/vc4_hdmi.c
index 65826a4f208e..ce18384c6be3 100644
--- a/drivers/gpu/drm/vc4/vc4_hdmi.c
+++ b/drivers/gpu/drm/vc4/vc4_hdmi.c
@@ -33,13 +33,9 @@
* interconnect) bus to the encoder side for insertion into the video
* blank regions.
*
- * The driver's HDMI encoder does not yet support power management.
- * The HDMI encoder's power domain and the HSM/pixel clocks are kept
- * continuously running, and only the HDMI logic and packet ram are
- * powered off/on at disable/enable time.
- *
- * The driver does not yet support CEC control, though the HDMI
- * encoder block has CEC support.
+ * Note that HDMI CEC requires that the HSM clock be running even when
+ * not scanning out, so that input can be processed. The PHY is still
+ * powered down when not scanning out, though.
*/
#include <drm/drm_atomic_helper.h>
--
2.14.1
prev parent reply other threads:[~2017-09-20 22:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-20 22:59 [PATCH 1/2] drm/vc4: Reject HDMI modes with too high of clocks Eric Anholt
2017-09-20 22:59 ` Eric Anholt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170920225935.14566-2-eric@anholt.net \
--to=eric@anholt.net \
--cc=boris.brezillon@free-electrons.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=hverkuil@xs4all.nl \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®