From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751734AbdIUM7i (ORCPT ); Thu, 21 Sep 2017 08:59:38 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:34593 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751550AbdIUM7h (ORCPT ); Thu, 21 Sep 2017 08:59:37 -0400 Date: Thu, 21 Sep 2017 15:59:18 +0300 From: Dan Carpenter To: Arvind Yadav Cc: rmfrfs@gmail.com, johan@kernel.org, elder@kernel.org, gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, greybus-dev@lists.linaro.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] media: staging: greybus: Release memory obtained by kasprintf Message-ID: <20170921125918.keiog5yd2jw342zc@mwanda> References: <21ea1d2e0ef0c3d4d59b2e5d2e189533c8b1668a.1505991013.git.arvind.yadav.cs@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <21ea1d2e0ef0c3d4d59b2e5d2e189533c8b1668a.1505991013.git.arvind.yadav.cs@gmail.com> User-Agent: NeoMutt/20170113 (1.7.2) X-Source-IP: aserv0021.oracle.com [141.146.126.233] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 21, 2017 at 05:05:27PM +0530, Arvind Yadav wrote: > Free memory region, if gb_lights_channel_config is not successful. > The question I have is do we free this on module unload? I don't see that we do. I feel like we should do a free after calling __gb_lights_led_unregister(). But that's awkward because we call __gb_lights_led_unregister() when this function fails so it would end up being a double free. > Signed-off-by: Arvind Yadav > --- > drivers/staging/greybus/light.c | 9 ++++++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git a/drivers/staging/greybus/light.c b/drivers/staging/greybus/light.c > index 3f4148c..b00d47c 100644 > --- a/drivers/staging/greybus/light.c > +++ b/drivers/staging/greybus/light.c > @@ -984,7 +984,7 @@ static int gb_lights_channel_config(struct gb_light *light, > > ret = channel_attr_groups_set(channel, cdev); > if (ret < 0) > - return ret; > + goto err; > > gb_lights_led_operations_set(channel, cdev); > > @@ -994,15 +994,18 @@ static int gb_lights_channel_config(struct gb_light *light, > * configurations. > */ > if (!is_channel_flash(channel)) > - return ret; > + goto err; "ret" is zero here. This is actually a success return. It would be cleaner to just write "return 0;". Anyway, this patch introduces a use after free so that doesn't work. Also it's better to choose a label name which says what the label does so in this case it would be "goto err_free_name" or "goto err_cdev_name" or whatever, but something to indicate that it's to do with freeing the cdev->name. Just "err" is too ambiguous. > > light->has_flash = true; > > ret = gb_lights_channel_flash_config(channel); > if (ret < 0) > - return ret; > + goto err; > > return ret; ^^^^^^^^^^ Here as well, change this from "return ret;" to "return 0;". regards, dan carpenter