From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751823AbdIVDLh (ORCPT ); Thu, 21 Sep 2017 23:11:37 -0400 Received: from smtprelay0038.hostedemail.com ([216.40.44.38]:48946 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751653AbdIVDLg (ORCPT ); Thu, 21 Sep 2017 23:11:36 -0400 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Spam-Summary: 50,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::,RULES_HIT:41:355:379:541:599:800:960:967:973:988:989:1260:1263:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2525:2553:2566:2682:2685:2693:2859:2933:2937:2939:2942:2945:2947:2951:2954:3022:3138:3139:3140:3141:3142:3352:3866:3867:3868:3872:3873:3934:3936:3938:3941:3944:3947:3950:3953:3956:3959:4605:5007:6261:7875:8829:9025:9040:9388:10004:10400:10848:10967:11232:11257:11658:11914:12043:12291:12555:12683:12740:12760:12895:13069:13255:13311:13357:13439:14096:14097:14181:14659:14721:21080:21451:21627:30054:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: brass14_822c7c18d4f40 X-Filterd-Recvd-Size: 2195 Date: Thu, 21 Sep 2017 23:11:32 -0400 From: Steven Rostedt To: Peter Zilstra Cc: Joel Fernandes , linux-kernel@vger.kernel.org, kernel-team@android.com Subject: Re: [PATCH v6 0/2] tracing: Add trace events for preemption and irq disable/enable Message-ID: <20170921231132.464a3236@vmware.local.home> In-Reply-To: <20170922015024.16123-1-joelaf@google.com> References: <20170922015024.16123-1-joelaf@google.com> X-Mailer: Claws Mail 3.15.0-dirty (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Peter, Do you have any qualms with this patch set? -- Steve On Thu, 21 Sep 2017 18:50:22 -0700 Joel Fernandes wrote: > These patches add trace events support for preempt and irq disable/enable > events. > > Changes since v5: > - Use trace_*_rcuidle variants (thanks Steve!) > > Here's an example of how Android's systrace will be using it to show critical > sections as a gantt chart: http://imgur.com/download/TZplEVp > > Links to earlier series: > v5: https://lkml.org/lkml/2017/9/12/507 > v4: https://lkml.org/lkml/2017/9/6/724 > v3: https://lkml.org/lkml/2017/9/3/15 > > Joel Fernandes (2): > tracing: Prepare to add preempt and irq trace events > tracing: Add support for preempt and irq enable/disable events > > include/linux/ftrace.h | 3 +- > include/linux/irqflags.h | 4 +- > include/trace/events/preemptirq.h | 66 ++++++++++++++ > kernel/trace/Kconfig | 9 ++ > kernel/trace/Makefile | 1 + > kernel/trace/trace_irqsoff.c | 176 +++++++++++++++++++++++++++++++------- > 6 files changed, 226 insertions(+), 33 deletions(-) > create mode 100644 include/trace/events/preemptirq.h > > Cc: Steven Rostedt > Cc: Peter Zilstra