From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752084AbdIVJy1 (ORCPT <rfc822;w@1wt.eu>);
        Fri, 22 Sep 2017 05:54:27 -0400
Received: from mail.linuxfoundation.org ([140.211.169.12]:60832 "EHLO
        mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751931AbdIVJy0 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 22 Sep 2017 05:54:26 -0400
Date: Fri, 22 Sep 2017 11:54:32 +0200
From: Greg KH <gregkh@linuxfoundation.org>
To: rui_feng@realsil.com.cn
Cc: lee.jones@linaro.org, arnd@arndb.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mfd: rtsx: Add support for RTS5260
Message-ID: <20170922095432.GA8112@kroah.com>
References: <1506072984-32415-1-git-send-email-rui_feng@realsil.com.cn>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <1506072984-32415-1-git-send-email-rui_feng@realsil.com.cn>
User-Agent: Mutt/1.9.0 (2017-09-02)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Sep 22, 2017 at 05:36:24PM +0800, rui_feng@realsil.com.cn wrote:
> From: rui_feng <rui_feng@realsil.com.cn>
> 
> Add support for new chip rts5260.
> In order to support rts5260，the definitions of some internal
> registers and workflow have to be modified and are different from its
> predecessors. So we need this patch to ensure RTS5260 can work.
> 
> Signed-off-by: Rui Feng <rui_feng@realsil.com.cn>

Nit, this name needs to match your "From:" line.  It almost does :)

Why is this a drivers/misc/ driver?

> --- /dev/null
> +++ b/drivers/misc/rts5260.c
> @@ -0,0 +1,590 @@
> +/* Driver for Realtek PCI-Express card reader
> + *
> + * Copyright(c) 2016-2017 Realtek Semiconductor Corp. All rights reserved.
> + *
> + * This program is free software; you can redistribute it and/or modify it
> + * under the terms of the GNU General Public License as published by the
> + * Free Software Foundation; either version 2, or (at your option) any
> + * later version.

Do you really mean "any later version"?  (I have to ask...)

> + *
> + * This program is distributed in the hope that it will be useful, but
> + * WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
> + * General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License along
> + * with this program; if not, see <http://www.gnu.org/licenses/>.
> + *
> + * Author:
> + *   Steven FENG <steven_feng@realsil.com.cn>
> + *   Rui FENG <rui_feng@realsil.com.cn>
> + *   Wei WANG <wei_wang@realsil.com.cn>
> + */
> +
> +#include <linux/module.h>
> +#include <linux/delay.h>
> +#include <linux/mfd/rtsx_pci.h>
> +
> +#include "../mfd/rtsx_pcr.h"

That looks "odd" :(

thanks,

greg k-h