From: Dan Carpenter <dan.carpenter@oracle.com>
To: SF Markus Elfring <elfring@users.sourceforge.net>
Cc: linux-media@vger.kernel.org, Davidlohr Bueso <dave@stgolabs.net>,
Hans Verkuil <hverkuil@xs4all.nl>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 2/4] [media] usbvision-core: Use common error handling code in usbvision_set_compress_params()
Date: Fri, 22 Sep 2017 14:44:32 +0300 [thread overview]
Message-ID: <20170922114432.x4e2ao22spbyek7n@mwanda> (raw)
In-Reply-To: <52c09836-83d7-c509-6e85-c7af16160302@users.sourceforge.net>
On Thu, Sep 21, 2017 at 05:07:06PM +0200, SF Markus Elfring wrote:
> @@ -1913,11 +1908,12 @@ static int usbvision_set_compress_params(struct usb_usbvision *usbvision)
> USB_DIR_OUT | USB_TYPE_VENDOR |
> USB_RECIP_ENDPOINT, 0,
> (__u16) USBVISION_PCM_THR1, value, 6, HZ);
> + if (rc < 0)
> +report_failure:
> + dev_err(&usbvision->dev->dev,
> + "%s: ERROR=%d. USBVISION stopped - reconnect or reload driver.\n",
> + __func__, rc);
You've been asked several times not to write code like this. You do
it later in the patch series as well.
regards,
dan carpenter
next prev parent reply other threads:[~2017-09-22 11:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-21 15:04 [PATCH 0/4] [media] usbvision-core: Fine-tuning for some function implementations SF Markus Elfring
2017-09-21 15:06 ` [PATCH 1/4] [media] usbvision-core: Use common error handling code in usbvision_set_input() SF Markus Elfring
2017-09-21 15:07 ` [PATCH 2/4] [media] usbvision-core: Use common error handling code in usbvision_set_compress_params() SF Markus Elfring
2017-09-22 11:44 ` Dan Carpenter [this message]
2017-09-22 14:50 ` SF Markus Elfring
2017-09-21 15:08 ` [PATCH 3/4] [media] usbvision-core: Delete unnecessary braces in 11 functions SF Markus Elfring
2017-09-22 11:42 ` Dan Carpenter
2017-09-22 15:03 ` SF Markus Elfring
2017-09-21 15:09 ` [PATCH 4/4] [media] usbvision-core: Replace four printk() calls by dev_err() SF Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170922114432.x4e2ao22spbyek7n@mwanda \
--to=dan.carpenter@oracle.com \
--cc=dave@stgolabs.net \
--cc=elfring@users.sourceforge.net \
--cc=hverkuil@xs4all.nl \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®