From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752276AbdIVPQz (ORCPT ); Fri, 22 Sep 2017 11:16:55 -0400 Received: from mail-qk0-f194.google.com ([209.85.220.194]:36871 "EHLO mail-qk0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751876AbdIVPQx (ORCPT ); Fri, 22 Sep 2017 11:16:53 -0400 X-Google-Smtp-Source: AOwi7QDKwDeRbn1lBJnhXL7FHwznlZhgD+ZdQnKcaG+ePEqTNsRh3C/KTrZgnRfa4m7g+4fyQMrq/w== Date: Fri, 22 Sep 2017 08:16:49 -0700 From: Tejun Heo To: Waiman Long Cc: Li Zefan , cgroups@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] cgroup: Reinit cgroup_taskset structure before cgroup_migrate_execute() returns Message-ID: <20170922151649.GE828415@devbig577.frc2.facebook.com> References: <1506002053-13380-1-git-send-email-longman@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1506002053-13380-1-git-send-email-longman@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 21, 2017 at 09:54:13AM -0400, Waiman Long wrote: ... > To allow reuse of the cgroup_mgctx structure, some fields in that > structure are now re-initialized at the end of cgroup_migrate_execute() > function call so that the structure can be reused again in a later > iteration without causing problem. > > This bug was introduced in the commit e595cd706982 ("group: track > migration context in cgroup_mgctx") in 4.11. This commit moves the > cgroup_taskset initialization out of cgroup_migrate(). The commit > 10467270fb3 ("cgroup: don't call migration methods if there are no > tasks to migrate") helped, but did not completely resolve the problem. > > Fixes: e595cd706982bff0211e6fafe5a108421e747fbc ("group: track migration context in cgroup_mgctx") > Signed-off-by: Waiman Long Applied to cgroup/for-4.14-fixes. Thanks, Waiman! -- tejun