From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752559AbdIVQoY (ORCPT ); Fri, 22 Sep 2017 12:44:24 -0400 Received: from mail-pg0-f45.google.com ([74.125.83.45]:52438 "EHLO mail-pg0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752020AbdIVQoV (ORCPT ); Fri, 22 Sep 2017 12:44:21 -0400 X-Google-Smtp-Source: AOwi7QDajRToDlx5NmaV7s2m2dxP9VONoIiDwySOrxDy4w7wRCaCRHGiG13ApprHGcmoKuS/BW/sSg== From: Douglas Anderson To: kishon@ti.com, heiko@sntech.de, zyw@rock-chips.com Cc: groeck@chromium.org, shawnn@chromium.org, dnschneid@chromium.org, Douglas Anderson , linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH v3 0/4] phy: rockchip-typec: Set "flip" properly; some cleanups; fix swing Date: Fri, 22 Sep 2017 09:44:02 -0700 Message-Id: <20170922164406.27606-1-dianders@chromium.org> X-Mailer: git-send-email 2.14.1.821.g8fa685d3b7-goog Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When connecting to certain DP monitors it was observed that only one of the two orientations of the type C to DP cable would work. Debugging showed that the problem was that we needed to set the type C "flip" state earlier. Once we did this, problems went away. While trying to dig into this problem and some others, I found that the proper documentation for the Type C PHY was available to me. This allowed me to cleanup the magic numbers in the funtion that I was touching and also fix a few minor issues that (luckily) haven't caused any problems yet. I also found that aux channel communications were flaky on some adapters until I adjusted the voltage swing. For this series I've added Chris Zhong's Reviewed-by tags to some of the patches since he gave a +1 to nearly identical patches on the Chrome OS gerrit and I didn't think he'd mind me carrying his tag. If folks would rather I didn't do that, please yell. Changes in v3: - Voltage swing patch now patch 2. Changes in v2: - Voltage swing patch new for v2. - Removed extra blank line. Douglas Anderson (4): phy: rockchip-typec: Set the AUX channel flip state earlier phy: rockchip-typec: Don't set the aux voltage swing to 400 mV phy: rockchip-typec: Avoid magic numbers + add delays in aux calib phy: rockchip-typec: Do the calibration more correctly drivers/phy/rockchip/phy-rockchip-typec.c | 246 ++++++++++++++++++++++++------ 1 file changed, 201 insertions(+), 45 deletions(-) -- 2.14.1.821.g8fa685d3b7-goog