From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752484AbdIVRSs (ORCPT ); Fri, 22 Sep 2017 13:18:48 -0400 Received: from mx0b-00082601.pphosted.com ([67.231.153.30]:56228 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752340AbdIVRSq (ORCPT ); Fri, 22 Sep 2017 13:18:46 -0400 Date: Fri, 22 Sep 2017 10:18:26 -0700 From: Roman Gushchin To: Konstantin Khlebnikov CC: Andrew Morton , Linus Torvalds , "linux-mm@kvack.org" , Alexander Viro , Ingo Molnar , , Linux Kernel Mailing List , Oleg Nesterov Subject: Re: [RESEND] proc, coredump: add CoreDumping flag to /proc/pid/status Message-ID: <20170922171826.GA1712@castle.DHCP.thefacebook.com> References: <20170914224431.GA9735@castle> <20170920230634.31572-1-guro@fb.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.0 (2017-09-02) X-Originating-IP: [2620:10d:c090:200::5:ca5c] X-ClientProxiedBy: MWHPR1301CA0022.namprd13.prod.outlook.com (2603:10b6:301:29::35) To CO1PR15MB1080.namprd15.prod.outlook.com (2a01:111:e400:7b66::10) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c0c7fcde-896b-46c1-15bf-08d501ddf2d5 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(300000502095)(300135100095)(22001)(2017030254152)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);SRVR:CO1PR15MB1080; X-Microsoft-Exchange-Diagnostics: 1;CO1PR15MB1080;3:zbzVsjAEJ7xjgYbVhgIvikNCP3zOXAFAsLMv4e0Yji1X5DrwNEKraLlTEyQxunGOxsMYatYdyRZnKJiFfXcNH/OLZtcQ5/4aJYSw12fFxOQgLYtMK31/PpFr+6hQM2mSt2Lw71UX2CHwQ+2cVLZ8bTI9oAulynaavJj8eM/CWQgef/gVuxeehhwy0htHS5Rg4sYUrYdCkcKkLwx7GD/hmFMdO7Kn0ZYKaF/Oejhi+OjR2TTl/40aZ5KI5/5IKFtc;25:qfl2p2IcNMO9YnKsGxPwS6dYT8kGVS2ojucPYLKBeLPIx3AgYE4V+47+AUuTb6o87NBlwke/eg6bFXDfb3iLooKhGL2Q+cZdxZFphmKpg8aYjeWBZAN82jLdvQds0vuh0ci1LBCllB2kpuF8+KijNco5LpKV6bvacerMuLgtSmDiJ86Q8i4XwZXo0MZOoeuDW8WjCAEXmpsmoQj1msvabdyhJiI8e1eQxiQgo3P8gaw3SlkW3fp1LFCobj60kiJSCWrN2uUioKKDoLEjAR4wnl1TTNd8D9hQPr3kmFiLJtBGH9DHUVtP9jnlfR5UjTmoJPeogs9Xg/2CiANLoKvIyg==;31:53Gq2dApbWiQ1W0/3rYa3+Fkpl6Uz897Cx9mlGrbtRB3CNLMjiqIkfudVU4wtGRnz3/rsDEyRGhJuRWWvr0kpuMKu+loGmFoZgv76wDOWTc8LJ7bKe/ROcY+U1jfKRB4xQbUsAnWK9WHaaGqc88HRD+3grD4bxDMoFD/sRMfLHU65mkuvtgOidgfoHkXct0HVk3yS6D6H+mjCknUOpY79WWrNooSeRo071t24IyCVkQ= X-MS-TrafficTypeDiagnostic: CO1PR15MB1080: X-Microsoft-Exchange-Diagnostics: 1;CO1PR15MB1080;20:yQ/xMA+CJMkEoUZjZa3RUGoGWtJ2iWnAaowwZT6K/pl8JIiau4bfCJT+G5gBI/DOtH5T6Ttv7UH5mGqRQ728Fvp4HP8WsMGDps8u2OrwchnhWRTtmI7Au50UaaclAguw6T9SmeZIjr0nZXNOogzWRDc97cRmXyH28MEWosih1O1IVgYHUd/9Scovxj3X2VL7SaUcdphxZYBdeYPb1DulbhFF9air0Sra8UWicoe3E0miEqnygUESTYyOKSG/iGFmrUwxk9A6R4JQMZRIJItK7PN+EtOYuB0AwJUJ143/q/DEwBXgmKNl92tOwk8ZE9K0iODuzpCJvJZMOMy5itZd8TudMYZIr1lP4V6ZE751/XJcEu2IeV3Y99/JI/zwkJv22cf0PML4LFBJGk6TaF5e+n5o3NG6oHxaYcupUJogzdBBIQliAXPa0tD05AncTXgIYZzPuzvpPXjMECGcdV97GOlneHbHHbwgNNnsVwcXG8+QuvZM25b4IJghj2fmzweV;4:kzEP11JDGqPiGNSqwbvpgpdnsgHsThI13JXx9nterePY/AtM5MGEh2bsfGu5s4JocGmEzOURS7zib86irZfPpaQCMNZepylM9uuy2kZcaPB06HGwlkPUEi87TLgK3kk62/bk4P0Ew7gwq9Xwq604oBFFiSXZq8oO7INHgAHyZcBT/kKYt7J1mCJjw/h8/XSjmeMx4W5PWE0OHFMA08OjwG0pLioI4ZnrCH1TOTEz0M2SqKKeYTfw/DarJC95pJKKY10miRRBkD2EDat/g0DMNLNUAzTD7N8kMfYZSAx3/ZIir5deLnNDCKRfcW6FGDdzN+lkAqG/ez41sj9ST4sBbA== X-Exchange-Antispam-Report-Test: UriScan:(72170088055959)(67672495146484); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(93006095)(93001095)(100000703101)(100105400095)(10201501046)(3002001)(6041248)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123562025)(20161123560025)(20161123555025)(20161123558100)(20161123564025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:CO1PR15MB1080;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:CO1PR15MB1080; X-Forefront-PRVS: 0438F90F17 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(6009001)(346002)(376002)(199003)(189002)(377454003)(24454002)(76176999)(54356999)(105586002)(50986999)(101416001)(1411001)(33656002)(97736004)(47776003)(50466002)(86362001)(316002)(83506001)(23726003)(106356001)(25786009)(4326008)(6506006)(68736007)(6116002)(478600001)(6916009)(55016002)(6666003)(6246003)(229853002)(2950100002)(2906002)(53546010)(53936002)(9686003)(7736002)(16586007)(189998001)(39060400002)(8936002)(1076002)(5660300001)(8676002)(81156014)(54906003)(81166006)(58126008)(305945005)(18370500001)(42262002);DIR:OUT;SFP:1102;SCL:1;SRVR:CO1PR15MB1080;H:castle.DHCP.thefacebook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;CO1PR15MB1080;23:e9XLz7fqofkqme4Cc/SqCIXzw5aHgYj4dA2iejboc?= =?us-ascii?Q?3jKvIcIQhjkV3W6gv5xtYnQ6y15T3lkOGr5BdI4INZnE2D8O9ycyPm/S/feU?= =?us-ascii?Q?tNWy7HCS/K3gXFojMKMT9fTRPszxrzpMwWYGISAwX1602Y44XM4kpxYLajPB?= =?us-ascii?Q?felGTYtkjbaDwqJ4w6/nMlRjkTfhLSPG5zXDtaKN556a0tkS+O3oK8YYKP8d?= =?us-ascii?Q?uEWhreqUXBYIGtInyY/iKR7uVad5/PP9eEsB5DvlaRTIWSFRUQb2BqmE/sq4?= =?us-ascii?Q?geopNIcHtbFI/GxkUGBLLeowL0tTHbMl0Q/zQZvsbzCjlokJHBT8CFhftKPO?= =?us-ascii?Q?PVyqnqLK4OpuOfJ2CmjxeyhfCdQqEgeW20PdvsLMCX5seZaeeKD1vghhfUIe?= =?us-ascii?Q?d5oj0i1Uak1ikhpHThx2fxzN1plAJEAaTTCnIyvNfWUumPTRy22qP2rzsv0A?= =?us-ascii?Q?VP0+titBUIJTrjXDjcyZL67IDZYcBxW4D3OOodpzyA/EkiS2BZv/v5hcPEST?= =?us-ascii?Q?z2MbLQXYjLFte2A/NHLbNldd6bwgt0C5ou450L5QflJm4N5PLoIpq1rDkXp9?= =?us-ascii?Q?M/3N6XN/TenDALgh94anpW6Js/5VOkXYlFk49oOsPYCd1OI9KHC87zH9Hxxh?= =?us-ascii?Q?RJCoGvkD2pDbagI0gD8M8VUPLNTltcjDVmt+gKZzPaD+90XehFQcISKNHDWz?= =?us-ascii?Q?heaYhJFh5BIly4rcR607KEXEGC2VyjUIqSUkbfrefXnsXRD/w/R9sshE+QdJ?= =?us-ascii?Q?oidUPQJNOnvobfnCabRTfZD8s7qLOwUQJBaok8LQeznbf11X65Nii8VF2jKu?= =?us-ascii?Q?9BUP3VpKaVyi2E1rvOAwL9xVM5WhgMBifJ8R13V5kCupRDXaNVnmsjGC27Mb?= =?us-ascii?Q?9HWzbh2hFFAS8l/6kxxFs/LPRksMpJ0clsj39G2IID4WOaP/EUBE/0Rwew+3?= =?us-ascii?Q?3BaKJJZ/VWoZAHtkoEp1KjeaBkmSU9xXGY+yA0CXDvJ76AWReIIZrg6rW4R7?= =?us-ascii?Q?x348Y8W4iCR8xGO9HRue8as7gNfAyz5g5eXTehUqtMJa19uPVPVNrbuuoOEo?= =?us-ascii?Q?VHFj3KxuFvFCxIlBsv55iCTd2jPz9bp0UahUOvc9+5VAwN/80J03tC1HVsR5?= =?us-ascii?Q?epc3zw0/t0GxUAF92gKHDKwKiQthXRpkJwoNBmRhC/cxYq7UA9nc7ZPJTiBe?= =?us-ascii?Q?hUYZrQ8o2F9FW9g26RVB6wDGfm1lA3H9SpjxCBdPVLkUb9o1dX98yPjhw=3D?= =?us-ascii?Q?=3D?= X-Microsoft-Exchange-Diagnostics: 1;CO1PR15MB1080;6:1chJDUYpyZ8Q5eDhqDT2h8YHhS043nUhtLwUCF6Puqj1zIGXidN5LXl9fyWXemcljQjMtLB8tgjdXazVfD0MO3W65TDgmAdD8Lgtid9fBf8YwBJ89wlQog0bCxd9+paKnBbhSP4krGgKb8LpDZv2Rgcl+i1M5vDZ3jjghJ2IWWeZrFr8w6/XMt6h58aeHSNaUlYLQ7K7+ajFQ7pD3aUnxxuJ1v5sPt5vrIecLLuAxvD7IL7F0OK3Vus4Y+Gu0cgdFFnXxgossCM8bWAVPAFDF5SP1mBnGKQP7cXZ2ZLtf/7DJL7UpYynPtVLIT9zDK1c1XN+gLZr8OCHv0/lxJKL6A==;5:eMImM2JcFYSs0jyK7mA2pb79gKRCUWpW+ptcWPz9i3cPWJbUV0Zh3kqS4+5q026k4Z0XQ/n+8/BtuLuygMasw47sELZy6cnL+zO1TE+vCwV3YkBn28k3Mn8IBJfctzUVijr+3/IMdme6K3Rcf8lnaA==;24:lDR5TQ1JKvgZCae16/wNs2j8HnQW/chEmSpNBmrTtesfqVf25dLAPRNKNB5ZJXrxSWd/HKQipeJCLHGoPGfVBiwaUeog2kMVAwid1bWsrmA=;7:N3nd2V6P4Av7z3JAaA9ZROuYhqw4HHwD1OvCGQZWC7HMFfHbvv7hJRGhJWJm63oJv3pM01+iyjk4FXBLh9mK0QYxwjYzHDgF+Mi7sdIOYoHFueuEbCTqckbiDXZb8pi+y85WSWHzVmnAIp8PPGlq2HyTFVUlKg1M0yEvD9vc7MHtmLFJtW/jU7oXcBbqoLlnh1ZXD/s3gbmqIR7EYYCw7POx8pqC+z7pv0B2scwHzsU= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;CO1PR15MB1080;20:OUs3Z3ROamxZUqzkH5su816d6d1AB35dj8xPrVheiDE7nvoFUq2Dpe8cd0Yv8cHwKl9S0HLVXtE1+BT/6o9pblEkj0S7ibHBpHUhuUobLbzmyhK0Mdzhe1mhAAaexR9rXLe+3+o45p9xbTW3cOM6XaqDYbC9XjJRu+LFi0KEa8U= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Sep 2017 17:18:31.2337 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR15MB1080 X-OriginatorOrg: fb.com X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-09-22_07:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 22, 2017 at 06:44:12PM +0300, Konstantin Khlebnikov wrote: > On Thu, Sep 21, 2017 at 2:06 AM, Roman Gushchin wrote: > > Right now there is no convenient way to check if a process is being > > coredumped at the moment. > > > > It might be necessary to recognize such state to prevent killing > > the process and getting a broken coredump. > > Writing a large core might take significant time, and the process > > is unresponsive during it, so it might be killed by timeout, > > if another process is monitoring and killing/restarting > > hanging tasks. > > > > To provide an ability to detect if a process is in the state of > > being coreduped, we can expose a boolean CoreDumping flag > > in /proc/pid/status. > > Makes sense. > > Maybe print this line only when task actually makes dump? I don't think we do this trick with any other fields... > And probably expose pid of coredump helper. It will be racy in most cases, so I'm not sure it worth it. What's the usecase? In any case, it sounds like a separate feature. > > Add Oleg into CC. Thank you!