From: Steven Rostedt <rostedt@goodmis.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Joel Fernandes <joelaf@google.com>,
LKML <linux-kernel@vger.kernel.org>,
kernel-team@android.com
Subject: Re: [PATCH v6 2/2] tracing: Add support for preempt and irq enable/disable events
Date: Mon, 25 Sep 2017 06:52:26 -0400 [thread overview]
Message-ID: <20170925065226.137ec45e@vmware.local.home> (raw)
In-Reply-To: <20170925103223.horr6amiunw6if3n@hirez.programming.kicks-ass.net>
On Mon, 25 Sep 2017 12:32:23 +0200
Peter Zijlstra <peterz@infradead.org> wrote:
> > You mean you want to trace all calls to preempt and irq off even if
> > preempt and irqs are already off?
>
> Sure, why not? This stuff naturally nests, and who is to say its not a
> useful thing to trace all of them?
>
> By also tracing the nested sections you can, for instance, see how much
> you'd really win by getting rid of the outer one. If, for instance, the
> outer only accounts for 1% of the time, while the inner ones are
> interlinked and span the other 99%, there's more work to do than if that
> were not the case.
If we do this we need a field to record if the preemption or irqs were
toggled by that call. Something that filters could easily be added to
only show what this patch set has.
-- Steve
next prev parent reply other threads:[~2017-09-25 10:52 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-22 1:50 [PATCH v6 0/2] tracing: Add trace events for preemption and irq disable/enable Joel Fernandes
2017-09-22 1:50 ` [PATCH v6 1/2] tracing: Prepare to add preempt and irq trace events Joel Fernandes
2017-09-22 1:50 ` [PATCH v6 2/2] tracing: Add support for preempt and irq enable/disable events Joel Fernandes
2017-09-22 9:02 ` Peter Zijlstra
2017-09-22 18:28 ` Joel Fernandes
2017-09-25 8:34 ` Peter Zijlstra
2017-09-25 10:15 ` Steven Rostedt
2017-09-25 10:32 ` Peter Zijlstra
2017-09-25 10:52 ` Steven Rostedt [this message]
2017-09-25 22:57 ` Joel Fernandes
2017-09-26 2:47 ` Steven Rostedt
2017-09-29 2:15 ` Joel Fernandes
2017-09-26 0:23 ` Joel Fernandes
2017-09-30 9:08 ` Steven Rostedt
2017-10-02 19:23 ` Joel Fernandes
2017-10-02 19:33 ` Joel Fernandes
2017-10-02 19:37 ` Steven Rostedt
2017-10-02 21:31 ` Joel Fernandes
2017-09-22 3:11 ` [PATCH v6 0/2] tracing: Add trace events for preemption and irq disable/enable Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170925065226.137ec45e@vmware.local.home \
--to=rostedt@goodmis.org \
--cc=joelaf@google.com \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome