From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935541AbdIYOT1 (ORCPT ); Mon, 25 Sep 2017 10:19:27 -0400 Received: from mail-wm0-f68.google.com ([74.125.82.68]:43938 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933355AbdIYOTZ (ORCPT ); Mon, 25 Sep 2017 10:19:25 -0400 X-Google-Smtp-Source: AOwi7QCRlrEfH5ST4Wnp2AOa1oRTJ9c/7CTFZLdxbuzt1LXccQ/goO1MHz44IEVQs6SQOlJUBTJOuQ== Date: Mon, 25 Sep 2017 15:19:21 +0100 From: Rui Miguel Silva To: Arvind Yadav Cc: johan@kernel.org, elder@kernel.org, gregkh@linuxfoundation.org, greybus-dev@lists.linaro.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] staging: greybus: light: Release memory obtained by kasprintf Message-ID: <20170925141921.GA21407@arch-late.localdomain> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Sat, Sep 23, 2017 at 01:25:30PM +0530, Arvind Yadav wrote: > Free memory region, if gb_lights_channel_config is not successful. > > Signed-off-by: Arvind Yadav Thanks for the patch, looks good to me. Reviewed-by: Rui Miguel Silva --- Cheers, Rui > --- > changes in v2: > - Subject line changed. > - add kfree in __gb_lights_led_unregister(). > - No need to check return value of gb_lights_channel_flash_config(). > > changes ib v3: > - separate patch for "No need to check return value of > gb_lights_channel_flash_config()". > > drivers/staging/greybus/light.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/staging/greybus/light.c b/drivers/staging/greybus/light.c > index 3f4148c..0f538b8 100644 > --- a/drivers/staging/greybus/light.c > +++ b/drivers/staging/greybus/light.c > @@ -925,6 +925,8 @@ static void __gb_lights_led_unregister(struct gb_channel *channel) > return; > > led_classdev_unregister(cdev); > + kfree(cdev->name); > + cdev->name = NULL; > channel->led = NULL; > } > > -- > 2.7.4 >