From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S936108AbdIYO6Z (ORCPT <rfc822;w@1wt.eu>);
        Mon, 25 Sep 2017 10:58:25 -0400
Received: from mail-pf0-f194.google.com ([209.85.192.194]:38849 "EHLO
        mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S935320AbdIYO6Y (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 25 Sep 2017 10:58:24 -0400
X-Google-Smtp-Source: AOwi7QBWzRp020bnTHNkYS+hzk1OHkj1D4dtKnZXJuVYngTnZWP2eVezQg1qOA7r3YoBaCWHK44IMg==
Date: Mon, 25 Sep 2017 07:58:21 -0700
From: Guenter Roeck <linux@roeck-us.net>
To: David Binderman <dcb314@hotmail.com>
Cc: "jdelvare@suse.com" <jdelvare@suse.com>,
        "linux-hwmon@vger.kernel.org" <linux-hwmon@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: linux-4.14-rc2/drivers/hwmon/pmbus/pmbus_core.c:1086]: (style)
 Redundant condition
Message-ID: <20170925145821.GA29763@roeck-us.net>
References: <VI1PR0802MB23367050B5690DAC7D654F0B9C7A0@VI1PR0802MB2336.eurprd08.prod.outlook.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <VI1PR0802MB23367050B5690DAC7D654F0B9C7A0@VI1PR0802MB2336.eurprd08.prod.outlook.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Sep 25, 2017 at 01:54:02PM +0000, David Binderman wrote:
> 
> Hello there,
> 
> linux-4.14-rc2/drivers/hwmon/pmbus/pmbus_core.c:1086]: (style) Redundant condition: upper. '!upper || (upper && data->has_status_word)' is equivalent to '!upper || data->has_status_word'
> 
> Source code is
> 
>            (!upper || (upper && data->has_status_word)) &&
> 
Please feel free to submit a patch.

Thanks,
Guenter