From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1031551AbdI0DDl (ORCPT ); Tue, 26 Sep 2017 23:03:41 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:46562 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1031086AbdI0DDk (ORCPT ); Tue, 26 Sep 2017 23:03:40 -0400 Date: Tue, 26 Sep 2017 20:03:39 -0700 (PDT) Message-Id: <20170926.200339.2029420994787006076.davem@davemloft.net> To: devtimhansen@gmail.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net/ipv4: Update sk_for_each_entry_offset_rcu macro to utilize rcu methods hlist_next_rcu. This fixes the warnings thrown by sparse regarding net/ipv4/udp.c on line 1974. From: David Miller In-Reply-To: <20170927005406.5935-1-devtimhansen@gmail.com> References: <20170927005406.5935-1-devtimhansen@gmail.com> X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 26 Sep 2017 20:03:39 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Tim Hansen Date: Tue, 26 Sep 2017 20:54:05 -0400 > Signed-off-by: Tim Hansen This is a poor patch submission on many levels. But the main problem, is that there is no use of sk_for_each_entry_offset_rcu() in any of my networking kernel trees. Referencing code by line number never works, you have to mention what version of the kernel, what tree, and where in what fucntion the problem is occurring. Secondly, sk_for_each_entry_offset_rcu() is not meant to be used in _raw() contexts. This is why it's not called sk_for_each_entry_offset_rcu_raw(). The sparse warning is probably legitimate, and points to a bug. But nobody can tell where becuase you haven't told us what tree and where this happens.