From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965819AbdIZGbH (ORCPT ); Tue, 26 Sep 2017 02:31:07 -0400 Received: from mail-pf0-f193.google.com ([209.85.192.193]:34440 "EHLO mail-pf0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964783AbdIZGbG (ORCPT ); Tue, 26 Sep 2017 02:31:06 -0400 X-Google-Smtp-Source: AOwi7QCkrYRFkLjX3Ke358eEjx2Sh5Kmh1uswS/qPuU3YLRvZ3kTSpnB2BqtsgWEUvW9B84l5d8k+g== Date: Tue, 26 Sep 2017 15:31:01 +0900 From: Sergey Senozhatsky To: Rob Herring Cc: Sergey Senozhatsky , Petr Mladek , Grant Likely , Sergey Senozhatsky , Steven Rostedt , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Andrew Lunn Subject: Re: [PATCH] of: do not leak console options Message-ID: <20170926063101.GA25762@jagdpanzerIV.localdomain> References: <20170825173647.1004-1-sergey.senozhatsky@gmail.com> <20170825223721.hilqpt5z4urevh6b@rob-hp-laptop> <20170827071910.GA581@tigerII.localdomain> <20170906124033.GB3143@pathway.suse.cz> <20170906132923.GA805@jagdpanzerIV.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On (09/06/17 10:27), Rob Herring wrote: [..] > > Rob, Grant, > > will this dirty hack work for you? I can respin the patch. > > Yes, as long as you intend to fix things later. Rob, sorry for the delay, I just sent out a simple patch. It contains that 'less-than-pretty' const cast. As of updating printk API -- I took a quick look... and there are quite a lot things to touch: not just printk.c, but also UART and all console drivers; we pass options not only to ->match() callback, but to ->setup() callback as well. I'm not sure I've got enough spare time for it right now, sorry. -ss