From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S967919AbdIZII1 (ORCPT ); Tue, 26 Sep 2017 04:08:27 -0400 Received: from mail-wm0-f66.google.com ([74.125.82.66]:36084 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S967138AbdIZIIX (ORCPT ); Tue, 26 Sep 2017 04:08:23 -0400 X-Google-Smtp-Source: AOwi7QCW48+UearsjZFtFBZGMC2p3H16+34os895YHnInkisLjgtFg2PizzxXro3OwPoMNhHghr8jA== Date: Tue, 26 Sep 2017 10:08:19 +0200 From: Daniel Vetter To: Mark yao Cc: Thomas Meyer , airlied@linux.ie, heiko@sntech.de, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 7/7] drm/rockchip: Cocci spatch "vma_pages" Message-ID: <20170926080819.23ujfvsbsmq4jwtd@phenom.ffwll.local> Mail-Followup-To: Mark yao , Thomas Meyer , airlied@linux.ie, heiko@sntech.de, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org References: <1505946334393-568186305-0-diffsplit-thomas@m3y3r.de> <1505946334393-988165015-7-diffsplit-thomas@m3y3r.de> <20170926051241.rwzpxlk4sfju7ctv@phenom.ffwll.local> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Operating-System: Linux phenom 4.12.0-1-amd64 User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 26, 2017 at 02:33:07PM +0800, Mark yao wrote: > On 2017年09月26日 13:12, Daniel Vetter wrote: > > On Thu, Sep 21, 2017 at 09:02:22AM +0800, Mark yao wrote: > > > On 2017年09月21日 06:29, Thomas Meyer wrote: > > > > Use vma_pages function on vma object instead of explicit computation. > > > > Found by coccinelle spatch "api/vma_pages.cocci" > > > > > > > > Signed-off-by: Thomas Meyer > > > > --- > > > Looks good for me: > > > Acked-by: Mark Yao > > Once more a maintainer who acks a patch and doesn't push it. This is > > really confusing, who exactly do you expect to handle this patch for you? > > > > Please push to drm-misc-next (also for future patches), thanks. > > -Daniel > > Hi Daniel > I Saw the patch title is "[PATCH 7/7]", I guessed it's one of a series of patches and maybe it can pushed by series. > > Ok, Pushed it to drm-misc-next. Hm right, but I only see 7/7 here. Either way, except when the author asks for a preferred tree it's best if you just pick things up right away. And if you're unsure, just ask instead of risking that a patch drops through the cracks. -Daniel > > > > > > > diff -u -p a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c > > > > --- a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c > > > > +++ b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c > > > > @@ -220,7 +220,7 @@ static int rockchip_drm_gem_object_mmap_ > > > > { > > > > struct rockchip_gem_object *rk_obj = to_rockchip_obj(obj); > > > > unsigned int i, count = obj->size >> PAGE_SHIFT; > > > > - unsigned long user_count = (vma->vm_end - vma->vm_start) >> PAGE_SHIFT; > > > > + unsigned long user_count = vma_pages(vma); > > > > unsigned long uaddr = vma->vm_start; > > > > unsigned long offset = vma->vm_pgoff; > > > > unsigned long end = user_count + offset; > > > > > > > > _______________________________________________ > > > > Linux-rockchip mailing list > > > > Linux-rockchip@lists.infradead.org > > > > http://lists.infradead.org/mailman/listinfo/linux-rockchip > > > > > > > > > > > > > > > -- > > > Ｍark Yao > > > > > > > > > _______________________________________________ > > > dri-devel mailing list > > > dri-devel@lists.freedesktop.org > > > https://lists.freedesktop.org/mailman/listinfo/dri-devel > > > -- > Ｍark Ya > > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch