From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S968352AbdIZJKU (ORCPT ); Tue, 26 Sep 2017 05:10:20 -0400 Received: from bombadil.infradead.org ([65.50.211.133]:47585 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965551AbdIZJKS (ORCPT ); Tue, 26 Sep 2017 05:10:18 -0400 Date: Tue, 26 Sep 2017 11:10:03 +0200 From: Peter Zijlstra To: Tejun Heo Cc: lizefan@huawei.com, hannes@cmpxchg.org, mingo@redhat.com, longman@redhat.com, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@fb.com, pjt@google.com, luto@amacapital.net, efault@gmx.de, torvalds@linux-foundation.org, guro@fb.com Subject: Re: [PATCH cgroup/for-4.15] sched/cputime: Add dummy cputime_adjust() implementation for CONFIG_VIRT_CPU_ACCOUNTING_NATIVE Message-ID: <20170926091003.3kpfdrero6hi262c@hirez.programming.kicks-ass.net> References: <20170811163754.3939102-1-tj@kernel.org> <20170925213421.GC560070@devbig577.frc2.facebook.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20170925213421.GC560070@devbig577.frc2.facebook.com> User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 25, 2017 at 02:34:21PM -0700, Tejun Heo wrote: > Hello, > > Another follow-up fix. I missed a dummy implementation leading to > bulid failure on s390. Because the bug and fix are trivial, I > directly applied the patch to cgroup/for-4.15. Please let me know if > it should be routed differently. > > Thanks. > ------ 8< ------ > From 8157a7faf94135386bf04b1cf94e6efd3fb94702 Mon Sep 17 00:00:00 2001 > From: Tejun Heo > Date: Mon, 25 Sep 2017 14:27:54 -0700 > MIME-Version: 1.0 > Content-Type: text/plain; charset=UTF-8 > Content-Transfer-Encoding: 8bit > > cfb766da54d9 ("sched/cputime: Expose cputime_adjust()") made > cputime_adjust() public for cgroup basic cpu stat support; however, > the commit forgot to add a dummy implementaiton for > CONFIG_VIRT_CPU_ACCOUNTING_NATIVE leading to compiler errors on some > s390 configurations. > > Fix it by adding the missing dummy implementation. > > Reported-by: “kbuild-all@01.org” > Fixes: cfb766da54d9 ("sched/cputime: Expose cputime_adjust()") > Signed-off-by: Tejun Heo Seems fine, Acked-by: Peter Zijlstra (Intel)