From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S969157AbdIZNO6 (ORCPT ); Tue, 26 Sep 2017 09:14:58 -0400 Received: from mail.free-electrons.com ([62.4.15.54]:54718 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S967144AbdIZNO4 (ORCPT ); Tue, 26 Sep 2017 09:14:56 -0400 Date: Tue, 26 Sep 2017 15:14:45 +0200 From: Maxime Ripard To: Quentin Schulz Cc: linus.walleij@linaro.org, robh+dt@kernel.org, mark.rutland@arm.com, wens@csie.org, linux@armlinux.org.uk, lee.jones@linaro.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@googlegroups.com, thomas.petazzoni@free-electrons.com Subject: Re: [PATCH v2 07/10] mfd: axp20x: add pinctrl cell for AXP813 Message-ID: <20170926131445.xo2uawiovjtmyivj@flea> References: <5345a2e94013f4e4f7b545cd4d84b098bd2fa349.1506428208.git-series.quentin.schulz@free-electrons.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="2cdrv6jxd25mp4ib" Content-Disposition: inline In-Reply-To: <5345a2e94013f4e4f7b545cd4d84b098bd2fa349.1506428208.git-series.quentin.schulz@free-electrons.com> User-Agent: NeoMutt/20170914 (1.9.0) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --2cdrv6jxd25mp4ib Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Sep 26, 2017 at 12:17:17PM +0000, Quentin Schulz wrote: > As pinctrl and GPIO driver now supports AXP813, add a cell for it. >=20 > Signed-off-by: Quentin Schulz > --- > drivers/mfd/axp20x.c | 3 +++ > 1 file changed, 3 insertions(+) >=20 > diff --git a/drivers/mfd/axp20x.c b/drivers/mfd/axp20x.c > index 336de66..a457528 100644 > --- a/drivers/mfd/axp20x.c > +++ b/drivers/mfd/axp20x.c > @@ -876,6 +876,9 @@ static struct mfd_cell axp813_cells[] =3D { > .name =3D "axp221-pek", > .num_resources =3D ARRAY_SIZE(axp803_pek_resources), > .resources =3D axp803_pek_resources, > + }, { > + .name =3D "axp20x-gpio", > + .of_compatible =3D "x-powers,axp813-pctl", This was probably introduced in the previous driver, but why are you using the pctl suffix? Can't we just use the GPIO one to remain consistent with the previous users and the datasheet? Thanks! Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com --2cdrv6jxd25mp4ib Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIcBAEBAgAGBQJZylLFAAoJEBx+YmzsjxAgUFcQAIGn3r/zLKy/AILyTVjFl0Jt DliBW+uTfdTTpZ1Qc3G9GYf1CzJF4MjMV/wWMypB5Flv76Ol0yxG32CE4ki4ATpH wCeDLH1BN6hQQn5qyAE4oyBDVVEuBKeMYpaLD1VMcAnRE7HW2+R7PEkRkPuueUch RYYkKAKJDdsAe9Nv4v6pUo6zBBo5abpJfCQeyTFL4vQqGOPdMVTr6wKpfqa6pykS 1swketHIfQ+GYZJNrWSwM3hEirmk4yLIFfrck6Tf18KYYiJw1YKba0A1o6QtRc/r ErvDasL9gfrvzQyv6vEylbvasc2l42Z+QDsGCGREqXKaQNfDVW2jMtIHrwVhm9rg oi0rMHbPiPbbRBhqga8vPwPT30WZqbJZ49h+faaOu05KG9eDUt54ZkY5gGQ/1X8C VzJJwX8bx1AUDlAxku/+KE2yVb+jBphK//aJbqywGrQoNyx0GL2g9Da/D4V4zDSl w7dcZ28WJ/1Q+T1Nw9zc19Re2wCHu7WO6PRf4g79idycIaKAKO0OkTxRsu29G+PA pBqf8AxlgAa9gUlPlr+2l6IXTBIHkBrlcSU4m8FPQjXPU0aGP0TvYYzPwajV2suA /QAYvPUj15kTjciuqt+49DbCOReNMuhQ+8k3xI8fkMVQQjv9jl4juFFgotDrJprJ 9CxYxoKJei2yt04t3AWU =sgAC -----END PGP SIGNATURE----- --2cdrv6jxd25mp4ib--