From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751921AbdI0VCl (ORCPT <rfc822;w@1wt.eu>);
        Wed, 27 Sep 2017 17:02:41 -0400
Received: from shards.monkeyblade.net ([184.105.139.130]:47872 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750788AbdI0VCj (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 27 Sep 2017 17:02:39 -0400
Date: Wed, 27 Sep 2017 14:02:38 -0700 (PDT)
Message-Id: <20170927.140238.1798928470383448433.davem@davemloft.net>
To: sam@ravnborg.org
Cc: vijay.ac.kumar@oracle.com, linux-kernel@vger.kernel.org,
        sparclinux@vger.kernel.org, babu.moger@oracle.com,
        rob.gardner@oracle.com
Subject: Re: [PATCH v2 2/2] sparc64: Use lzcnt instruction for fls and __fls
From: David Miller <davem@davemloft.net>
In-Reply-To: <20170927195637.GB15193@ravnborg.org>
References: <1506540326-9604-1-git-send-email-vijay.ac.kumar@oracle.com>
        <1506540326-9604-3-git-send-email-vijay.ac.kumar@oracle.com>
        <20170927195637.GB15193@ravnborg.org>
X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 27 Sep 2017 14:02:39 -0700 (PDT)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Sam Ravnborg <sam@ravnborg.org>
Date: Wed, 27 Sep 2017 21:56:37 +0200

> Hi Vijay.
> 
> On Wed, Sep 27, 2017 at 01:25:26PM -0600, Vijay Kumar wrote:
>> For T4 and above, patch fls and __fls functions
>> at the boot time to use lzcnt instruction.
>> 
>> Signed-off-by: Vijay Kumar <vijay.ac.kumar@oracle.com>
>> Reviewed-by: Babu Moger <babu.moger@oracle.com>
>> ---
>>  arch/sparc/Makefile         |    1 +
>>  arch/sparc/kernel/head_64.S |    2 ++
>>  arch/sparc/lib/Makefile     |    3 +++
>>  arch/sparc/lib/NG4fls.S     |   30 ++++++++++++++++++++++++++++++
>>  arch/sparc/lib/NG4patch.S   |    9 +++++++++
>>  5 files changed, 45 insertions(+), 0 deletions(-)
>> 
>> diff --git a/arch/sparc/Makefile b/arch/sparc/Makefile
>> index 8496a07..0763cd8 100644
>> --- a/arch/sparc/Makefile
>> +++ b/arch/sparc/Makefile
>> @@ -48,6 +48,7 @@ KBUILD_CFLAGS += -ffixed-g4 -ffixed-g5 -fcall-used-g7 -Wno-sign-compare
>>  KBUILD_CFLAGS += -Wa,--undeclared-regs
>>  KBUILD_CFLAGS += $(call cc-option,-mtune=ultrasparc3)
>>  KBUILD_AFLAGS += -m64 -mcpu=ultrasparc -Wa,--undeclared-regs
>> +KBUILD_AFLAGS += -Wa,-Asparc4
> This change is not justified anywhere??

It also will likely break with older tools.