From: David Miller <davem@davemloft.net>
To: linux@roeck-us.net
Cc: sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sparc: Provide cmpxchg64 for 32-bit builds
Date: Wed, 27 Sep 2017 21:38:12 -0700 (PDT) [thread overview]
Message-ID: <20170927.213812.1333158312684109871.davem@davemloft.net> (raw)
In-Reply-To: <1506274171-28423-1-git-send-email-linux@roeck-us.net>
From: Guenter Roeck <linux@roeck-us.net>
Date: Sun, 24 Sep 2017 10:29:31 -0700
> Fix the following build error, seen when building sparc32:allmodconfig.
>
> drivers/net/ethernet/intel/i40e/i40e_ethtool.c:
> In function 'i40e_set_priv_flags':
> drivers/net/ethernet/intel/i40e/i40e_ethtool.c:4150:2: error:
> implicit declaration of function 'cmpxchg64'
>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
That fixes the build:
> @@ -72,5 +72,6 @@ __cmpxchg(volatile void *ptr, unsigned long old, unsigned long new_, int size)
> ((__typeof__(*(ptr)))__cmpxchg_local_generic((ptr), (unsigned long)(o),\
> (unsigned long)(n), sizeof(*(ptr))))
> #define cmpxchg64_local(ptr, o, n) __cmpxchg64_local_generic((ptr), (o), (n))
> +#define cmpxchg64(ptr, o, n) cmpxchg64_local((ptr), (o), (n))
>
> #endif /* __ARCH_SPARC_CMPXCHG__ */
but it's wrong. cmpxchg64_local() is only atomic on the current cpu
so using it for plain cmpxchg64() is not going to work.
next prev parent reply other threads:[~2017-09-28 4:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-24 17:29 Guenter Roeck
2017-09-28 4:38 ` David Miller [this message]
2017-09-28 4:55 ` Guenter Roeck
2017-09-28 5:28 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170927.213812.1333158312684109871.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®