From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752778AbdI0M2r (ORCPT ); Wed, 27 Sep 2017 08:28:47 -0400 Received: from regular1.263xmail.com ([211.150.99.137]:49819 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752358AbdI0M2q (ORCPT ); Wed, 27 Sep 2017 08:28:46 -0400 X-263anti-spam: KSV:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-RL-SENDER: jeffy.chen@rock-chips.com X-FST-TO: linux-kernel@vger.kernel.org X-SENDER-IP: 103.29.142.67 X-LOGIN-NAME: jeffy.chen@rock-chips.com X-UNIQUE-TAG: X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 From: Jeffy Chen To: linux-kernel@vger.kernel.org Cc: Jeffy Chen , Thomas Gleixner Subject: [PATCH] irq/generic-chip: Fix memory leak of domain->name Date: Wed, 27 Sep 2017 20:28:16 +0800 Message-Id: <20170927122816.18931-1-jeffy.chen@rock-chips.com> X-Mailer: git-send-email 2.11.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Free domain->name when IRQ_DOMAIN_NAME_ALLOCATED been set. Fixes: d59f6617eef0 ("genirq: Allow fwnode to carry name information only") Signed-off-by: Jeffy Chen --- kernel/irq/generic-chip.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/kernel/irq/generic-chip.c b/kernel/irq/generic-chip.c index f7086b78ad6e..174dae8ee7fe 100644 --- a/kernel/irq/generic-chip.c +++ b/kernel/irq/generic-chip.c @@ -322,6 +322,10 @@ int __irq_alloc_domain_generic_chips(struct irq_domain *d, int irqs_per_chip, /* Calc pointer to the next generic chip */ tmp += sizeof(*gc) + num_ct * sizeof(struct irq_chip_type); } + if (d->flags & IRQ_DOMAIN_NAME_ALLOCATED) { + kfree(d->name); + d->flags &= ~IRQ_DOMAIN_NAME_ALLOCATED; + } d->name = name; return 0; } -- 2.11.0