From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751969AbdI0RyR convert rfc822-to-8bit (ORCPT ); Wed, 27 Sep 2017 13:54:17 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:27635 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751408AbdI0RyP (ORCPT ); Wed, 27 Sep 2017 13:54:15 -0400 Date: Wed, 27 Sep 2017 13:54:08 -0400 From: Konrad Rzeszutek Wilk To: Wanpeng Li Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, Paolo Bonzini , Radim =?utf-8?B?S3LEjW3DocWZ?= , Wanpeng Li Subject: Re: [PATCH 2/2] KVM: VMX: Don't expose PLE enable if there is no hardware support Message-ID: <20170927175408.GB2598@char.us.oracle.com> References: <1506494062-25533-1-git-send-email-wanpeng.li@hotmail.com> <1506494062-25533-2-git-send-email-wanpeng.li@hotmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1506494062-25533-2-git-send-email-wanpeng.li@hotmail.com> User-Agent: Mutt/1.8.3 (2017-05-23) Content-Transfer-Encoding: 8BIT X-Source-IP: userv0022.oracle.com [156.151.31.74] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 26, 2017 at 11:34:22PM -0700, Wanpeng Li wrote: > From: Wanpeng Li > > PLE_Window: Software can configure this field as an upper bound on the amount of time > a guest is allowed to execute in a PAUSE LOOP. > > KVM doesn't expose the PLE capability to the L1 hypervsior, however, ple_window still s/hypervsior/hypervisor/ > shows the default value on L1 hypervsior. This patch fixes it by clearing all the Ditto here. > PLE related module parameter if there is no PLE capability. > > Cc: Paolo Bonzini > Cc: Radim Krčmář > Signed-off-by: Wanpeng Li Reviewed-by: Konrad Rzeszutek Wilk > --- > arch/x86/kvm/vmx.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c > index c83d28b..4d4f9b4 100644 > --- a/arch/x86/kvm/vmx.c > +++ b/arch/x86/kvm/vmx.c > @@ -6781,8 +6781,13 @@ static __init int hardware_setup(void) > if (enable_ept && !cpu_has_vmx_ept_2m_page()) > kvm_disable_largepages(); > > - if (!cpu_has_vmx_ple()) > + if (!cpu_has_vmx_ple()) { > ple_gap = 0; > + ple_window = 0; > + ple_window_grow = 0; > + ple_window_max = 0; > + ple_window_shrink = 0; > + } > > if (!cpu_has_vmx_apicv()) { > enable_apicv = 0; > -- > 2.7.4 >