From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752069AbdI1ITo (ORCPT <rfc822;w@1wt.eu>);
        Thu, 28 Sep 2017 04:19:44 -0400
Received: from mail-wm0-f67.google.com ([74.125.82.67]:49428 "EHLO
        mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750981AbdI1ITm (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 28 Sep 2017 04:19:42 -0400
X-Google-Smtp-Source: AOwi7QDl3m7pO4K2EDBpODPo8owlXaVlEzywQPyESKUa6Ne8tA4sbOCRfhySM69/gwKjLfbcUAHVTg==
Date: Thu, 28 Sep 2017 10:19:39 +0200
From: Ingo Molnar <mingo@kernel.org>
To: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
Cc: Ingo Molnar <mingo@redhat.com>,
        Linus Torvalds <torvalds@linux-foundation.org>, x86@kernel.org,
        Thomas Gleixner <tglx@linutronix.de>, "H. Peter Anvin" <hpa@zytor.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Andy Lutomirski <luto@amacapital.net>,
        Cyrill Gorcunov <gorcunov@openvz.org>, Borislav Petkov <bp@suse.de>,
        linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCHv7 07/19] x86/mm: Make virtual memory layout movable for
 CONFIG_X86_5LEVEL
Message-ID: <20170928081939.nvrf25spnzgtyckz@gmail.com>
References: <20170918105553.27914-1-kirill.shutemov@linux.intel.com>
 <20170918105553.27914-8-kirill.shutemov@linux.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170918105553.27914-8-kirill.shutemov@linux.intel.com>
User-Agent: NeoMutt/20170113 (1.7.2)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


* Kirill A. Shutemov <kirill.shutemov@linux.intel.com> wrote:

> We need to be able to adjust virtual memory layout at runtime to be able
> to switch between 4- and 5-level paging at boot-time.
> 
> KASLR already has movable __VMALLOC_BASE, __VMEMMAP_BASE and __PAGE_OFFSET.
> Let's re-use it.
> 
> Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
> ---
>  arch/x86/include/asm/kaslr.h            | 4 ----
>  arch/x86/include/asm/page_64.h          | 4 ++++
>  arch/x86/include/asm/page_64_types.h    | 2 +-
>  arch/x86/include/asm/pgtable_64_types.h | 2 +-
>  arch/x86/kernel/head64.c                | 9 +++++++++
>  arch/x86/mm/kaslr.c                     | 8 --------
>  6 files changed, 15 insertions(+), 14 deletions(-)

> +#if defined(CONFIG_RANDOMIZE_MEMORY) || defined(CONFIG_X86_5LEVEL)
> +#if defined(CONFIG_RANDOMIZE_MEMORY) || defined(CONFIG_X86_5LEVEL)
> +#if defined(CONFIG_RANDOMIZE_MEMORY) || defined(CONFIG_X86_5LEVEL)

Yeah, so this calls for a new, properly named Kconfig helper variable.

Thanks,

	Ingo