From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752044AbdI1IZU (ORCPT <rfc822;w@1wt.eu>);
        Thu, 28 Sep 2017 04:25:20 -0400
Received: from mail-wr0-f196.google.com ([209.85.128.196]:32979 "EHLO
        mail-wr0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751816AbdI1IZS (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 28 Sep 2017 04:25:18 -0400
X-Google-Smtp-Source: AOwi7QBg/GWlKSTMrxEfAYEiJVc+uQSeQ+yPa/NLf2hD9Dijnv1EIvMOb34MOf4f+8AIFqbdwODBAw==
Date: Thu, 28 Sep 2017 10:25:14 +0200
From: Ingo Molnar <mingo@kernel.org>
To: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
Cc: Ingo Molnar <mingo@redhat.com>,
        Linus Torvalds <torvalds@linux-foundation.org>, x86@kernel.org,
        Thomas Gleixner <tglx@linutronix.de>, "H. Peter Anvin" <hpa@zytor.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Andy Lutomirski <luto@amacapital.net>,
        Cyrill Gorcunov <gorcunov@openvz.org>, Borislav Petkov <bp@suse.de>,
        linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCHv7 09/19] x86/mm: Make MAX_PHYSADDR_BITS and
 MAX_PHYSMEM_BITS dynamic
Message-ID: <20170928082514.tl6tuigmx6oleus6@gmail.com>
References: <20170918105553.27914-1-kirill.shutemov@linux.intel.com>
 <20170918105553.27914-10-kirill.shutemov@linux.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170918105553.27914-10-kirill.shutemov@linux.intel.com>
User-Agent: NeoMutt/20170113 (1.7.2)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


* Kirill A. Shutemov <kirill.shutemov@linux.intel.com> wrote:

> For boot-time switching between paging modes, we need to be able to
> adjust size of physical address space at runtime.
> 
> As part of making physical address space size variable, we have to make
> X86_5LEVEL dependent on SPARSEMEM_VMEMMAP. !SPARSEMEM_VMEMMAP
> configuration doesn't work well with variable MAX_PHYSMEM_BITS.
> 
> Affect on kernel image size:
> 
>    text    data     bss     dec     hex filename
> 10710340        4880000  860160 16450500         fb03c4 vmlinux.before
> 10710666        4880000  860160 16450826         fb050a vmlinux.after
> 
> Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
> ---
>  arch/x86/Kconfig                        | 1 +
>  arch/x86/include/asm/pgtable_64_types.h | 2 +-
>  arch/x86/include/asm/sparsemem.h        | 9 ++-------
>  arch/x86/kernel/setup.c                 | 5 ++---
>  4 files changed, 6 insertions(+), 11 deletions(-)
> 
> diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
> index 6a15297140ff..f75723d62c25 100644
> --- a/arch/x86/Kconfig
> +++ b/arch/x86/Kconfig
> @@ -1403,6 +1403,7 @@ config X86_PAE
>  config X86_5LEVEL
>  	bool "Enable 5-level page tables support"
>  	depends on X86_64
> +	depends on SPARSEMEM_VMEMMAP

Adding a 'depends on' to random kernel internal implementational details, to 
support new hardware, sucks as an UI, as it will just randomly hide/show the new 
hardware option if certain magic Kconfig combinations are set.

Please check how other architectures are doing it. (Hint: they are using select.)

Also, what is the real dependency here? Why don't the other memory models work, 
what's the failure mode - won't build, won't boot, or misbehaves in some other 
way?

Thanks,

	Ingo