From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753237AbdI1N0N (ORCPT <rfc822;w@1wt.eu>);
        Thu, 28 Sep 2017 09:26:13 -0400
Received: from mail-wm0-f66.google.com ([74.125.82.66]:34086 "EHLO
        mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1753197AbdI1N0L (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 28 Sep 2017 09:26:11 -0400
X-Google-Smtp-Source: AOwi7QBhNGbS29apvkrq4LGD3DT9VIMlTQiKxQNjzqOSkm4C1p9acZ8RN9LMIPMkyOaaIrriD56Cdw==
Date: Thu, 28 Sep 2017 16:26:08 +0300
From: "Kirill A. Shutemov" <kirill@shutemov.name>
To: Ingo Molnar <mingo@kernel.org>
Cc: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
        Ingo Molnar <mingo@redhat.com>,
        Linus Torvalds <torvalds@linux-foundation.org>, x86@kernel.org,
        Thomas Gleixner <tglx@linutronix.de>, "H. Peter Anvin" <hpa@zytor.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Andy Lutomirski <luto@amacapital.net>,
        Cyrill Gorcunov <gorcunov@openvz.org>, Borislav Petkov <bp@suse.de>,
        linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCHv7 12/19] x86/mm: Adjust virtual address space layout in
 early boot.
Message-ID: <20170928132608.priml7nc7dmo5r6d@node.shutemov.name>
References: <20170918105553.27914-1-kirill.shutemov@linux.intel.com>
 <20170918105553.27914-13-kirill.shutemov@linux.intel.com>
 <20170928083155.7qahecaeifz5em5f@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170928083155.7qahecaeifz5em5f@gmail.com>
User-Agent: NeoMutt/20170609 (1.8.3)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Sep 28, 2017 at 10:31:55AM +0200, Ingo Molnar wrote:
> 
> * Kirill A. Shutemov <kirill.shutemov@linux.intel.com> wrote:
> 
> > We need to adjust virtual address space to support switching between
> > paging modes.
> > 
> > The adjustment happens in __startup_64().
> 
> > +#ifdef CONFIG_X86_5LEVEL
> > +	if (__read_cr4() & X86_CR4_LA57) {
> > +		pgtable_l5_enabled = 1;
> > +		pgdir_shift = 48;
> > +		ptrs_per_p4d = 512;
> > +	}
> > +#endif
> 
> So CR4 really sucks as a parameter passing interface - was it us who enabled LA57 
> in the early boot code, right? Couldn't we add a flag which gets set there, or 
> something?

It's not necessary that we enabled LA57. At least I tried to write code
that doesn't assume this. We enable it if bootloader haven't done this
already for us.

What is so awful about using CR4 as passing interface? It's one-time
check, so performance shouldn't be an issue.

-- 
 Kirill A. Shutemov