From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753363AbdI1PLS (ORCPT ); Thu, 28 Sep 2017 11:11:18 -0400 Received: from mail.free-electrons.com ([62.4.15.54]:49439 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753341AbdI1PLP (ORCPT ); Thu, 28 Sep 2017 11:11:15 -0400 Date: Thu, 28 Sep 2017 17:11:03 +0200 From: Maxime Ripard To: Icenowy Zheng Cc: Chen-Yu Tsai , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com Subject: Re: [PATCH v2 1/3] ARM: dts: sun8i: Add basic dtsi file for Allwinner R40 Message-ID: <20170928151103.ov3o5pn5h7inzzan@flea> References: <20170928092543.45648-1-icenowy@aosc.io> <20170928092543.45648-2-icenowy@aosc.io> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="i2udpxaukzgohm6x" Content-Disposition: inline In-Reply-To: <20170928092543.45648-2-icenowy@aosc.io> User-Agent: NeoMutt/20170914 (1.9.0) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --i2udpxaukzgohm6x Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Thu, Sep 28, 2017 at 09:25:41AM +0000, Icenowy Zheng wrote: > + /* > + * The max-frequency properties in all MMC controller nodes > + * are conservative values proven to work on Banana Pi M2 > + * Ultra (the first community available R40 board). > + * As the board doesn't wire MMC3 out, the property is not > + * set in MMC3. > + * TODO: measure the accurate max frequency of the controllers. > + */ > + mmc0: mmc@1c0f000 { > + compatible =3D "allwinner,sun8i-r40-mmc", > + "allwinner,sun50i-a64-mmc"; > + reg =3D <0x01c0f000 0x1000>; > + clocks =3D <&ccu CLK_BUS_MMC0>, <&ccu CLK_MMC0>; > + clock-names =3D "ahb", "mmc"; > + resets =3D <&ccu RST_BUS_MMC0>; > + reset-names =3D "ahb"; > + pinctrl-0 =3D <&mmc0_pins>; > + pinctrl-names =3D "default"; > + interrupts =3D ; > + max-frequency =3D <25000000>; > + status =3D "disabled"; > + #address-cells =3D <1>; > + #size-cells =3D <0>; > + }; Sorry if it wasn't really clear, but my point was more than you should just drop the max-frequency property Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com --i2udpxaukzgohm6x Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIcBAEBAgAGBQJZzREHAAoJEBx+YmzsjxAgwKQP/RIfm4vzLaRFiNHwylLqT6zM rAbKC4hZGkRVTT48L7yW7F+ijhRV7sAbVJptlq8a0UMZcAQus6XlkGU4ZTb5tGeB A/Ubi1yAZqxKJGQxEc1QWNGcDOj3Yick79dbRimlC/eCcslu7XPd7pDYNVhcVg3j 7eLQpZ+XrppvDOpDrlgkUyIlXyOk0U8J3sDpxP0fVSc1hm1d4dDWPCGsGqEX62Q1 JerGzmPjfwxbHNlw0CrmjNI/LNud9VnAlQc0p3Di2Mddqny5Rex2V9lMhCto/rvy KDuCUN7UlRAFomNcvtaXhGfXmp3PA1Gvda/DnmNHXb6dZ3sPbktfNRmtYZskH8TA VCUzxsY6F1Jqv/E8N1WXgwlQWmnp4UmZd+DsOf+8X6Oxti4D/KwUNTq/jK3NdQ/r /9AqEjjpA+Cg1u4XsTezxxBQ3uiSbFj1qoqInCeQyNHjsfrdR0lkab6/kzqvhHgy 5Ef0WCC1VzsRtID+Tzn2hySApDETiYYrgaVv0T4qXn61eAv/4ibKNg3Qj5r7AM10 CeHoI+/PLGtJR722791gyqKfPNrzhNqyWSjttl9bbHagZ1pERwQUb7/2y0krTmEu 7NueuMim630sTVEG20x4A5QgsiU/xqF4Ncfqo947xdyq3dCldqvGwTvOVs7SzuqV v9EsZrTGfERH1fpIHHOu =mjf2 -----END PGP SIGNATURE----- --i2udpxaukzgohm6x--