From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751376AbdI1TGV (ORCPT ); Thu, 28 Sep 2017 15:06:21 -0400 Received: from mail-pf0-f178.google.com ([209.85.192.178]:50750 "EHLO mail-pf0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750775AbdI1TGT (ORCPT ); Thu, 28 Sep 2017 15:06:19 -0400 X-Google-Smtp-Source: AOwi7QDNSDpaSx4+dhUAwV7+PAqn+hoQIt9Pk3DmsaQezWvcTLcU62URHTKoPADr74KluSv9iZuhrA== Date: Thu, 28 Sep 2017 20:06:14 +0100 From: Lee Jones To: Maxime Ripard Cc: Quentin Schulz , linus.walleij@linaro.org, robh+dt@kernel.org, mark.rutland@arm.com, wens@csie.org, linux@armlinux.org.uk, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@googlegroups.com, thomas.petazzoni@free-electrons.com Subject: Re: [PATCH v2 07/10] mfd: axp20x: add pinctrl cell for AXP813 Message-ID: <20170928190614.v5jgejvgdlyxbxrh@dell> References: <5345a2e94013f4e4f7b545cd4d84b098bd2fa349.1506428208.git-series.quentin.schulz@free-electrons.com> <20170926131445.xo2uawiovjtmyivj@flea> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20170926131445.xo2uawiovjtmyivj@flea> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 26 Sep 2017, Maxime Ripard wrote: > On Tue, Sep 26, 2017 at 12:17:17PM +0000, Quentin Schulz wrote: > > As pinctrl and GPIO driver now supports AXP813, add a cell for it. > > > > Signed-off-by: Quentin Schulz > > --- > > drivers/mfd/axp20x.c | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/drivers/mfd/axp20x.c b/drivers/mfd/axp20x.c > > index 336de66..a457528 100644 > > --- a/drivers/mfd/axp20x.c > > +++ b/drivers/mfd/axp20x.c > > @@ -876,6 +876,9 @@ static struct mfd_cell axp813_cells[] = { > > .name = "axp221-pek", > > .num_resources = ARRAY_SIZE(axp803_pek_resources), > > .resources = axp803_pek_resources, > > + }, { > > + .name = "axp20x-gpio", > > + .of_compatible = "x-powers,axp813-pctl", > > This was probably introduced in the previous driver, but why are you > using the pctl suffix? Can't we just use the GPIO one to remain > consistent with the previous users and the datasheet? Right. Pinctrl is a Linuxisum. GPIO sounds more appropriate. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog