From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751692AbdI1TWy (ORCPT ); Thu, 28 Sep 2017 15:22:54 -0400 Received: from mail-pf0-f176.google.com ([209.85.192.176]:46582 "EHLO mail-pf0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750832AbdI1TWt (ORCPT ); Thu, 28 Sep 2017 15:22:49 -0400 X-Google-Smtp-Source: AOwi7QBq8VruxddRgmOeOToX7W8NEz4cQymCeR/xLYWqXQF4UJlneVcARC1NvJABA0pFqB8jZ80lsg== Date: Thu, 28 Sep 2017 20:22:44 +0100 From: Lee Jones To: Enric Balletbo i Serra Cc: Benson Leung , gwendal@chromium.org, groeck@chromium.org, linux-kernel@vger.kernel.org, thierry.escande@collabora.com Subject: Re: [PATCH] mfd: cros_ec: move cros_ec_dev driver to MFD subdir. Message-ID: <20170928192244.rtmoovk22zwfsl2x@dell> References: <20170925200447.6356-1-enric.balletbo@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20170925200447.6356-1-enric.balletbo@collabora.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 25 Sep 2017, Enric Balletbo i Serra wrote: > The cros_ec_dev serves multiple purposes, one is register dinamically the > MFD subdevices by checking the features available in a specific ChromeOS > Embedded Controller, hence there are different calls to mfd_add_devices. > The first time we upstreamed this driver was placed in > drivers/platform/chrome, but call mfd_add_devices outside MFD is wrong. > As cros_ec_dev driver is strongly related to the MFD cros-ec-core would > make sense move the driver to the mfd subdir. > > This patch also fixes a small module loading issue, the name of the driver > in the C code was not matching their Makefile names, this prevented the > driver from loaded as module. > > Signed-off-by: Enric Balletbo i Serra > --- > drivers/mfd/Kconfig | 9 +++++++++ > drivers/mfd/Makefile | 4 ++++ > drivers/{platform/chrome => mfd}/cros_ec_debugfs.c | 0 > drivers/{platform/chrome => mfd}/cros_ec_debugfs.h | 0 > drivers/{platform/chrome => mfd}/cros_ec_dev.c | 5 ++++- > drivers/{platform/chrome => mfd}/cros_ec_dev.h | 0 > drivers/{platform/chrome => mfd}/cros_ec_lightbar.c | 0 > drivers/{platform/chrome => mfd}/cros_ec_sysfs.c | 0 > drivers/{platform/chrome => mfd}/cros_ec_vbc.c | 0 > drivers/platform/chrome/Kconfig | 9 --------- > drivers/platform/chrome/Makefile | 4 ---- > 11 files changed, 17 insertions(+), 14 deletions(-) > rename drivers/{platform/chrome => mfd}/cros_ec_debugfs.c (100%) > rename drivers/{platform/chrome => mfd}/cros_ec_debugfs.h (100%) > rename drivers/{platform/chrome => mfd}/cros_ec_dev.c (99%) > rename drivers/{platform/chrome => mfd}/cros_ec_dev.h (100%) > rename drivers/{platform/chrome => mfd}/cros_ec_lightbar.c (100%) > rename drivers/{platform/chrome => mfd}/cros_ec_sysfs.c (100%) > rename drivers/{platform/chrome => mfd}/cros_ec_vbc.c (100%) This is not what I had in mind. Only the MFD portion (the part which registers other devices) should live in drivers/mfd. Everything else should either live in their respective subsystem(s) or in drivers/platform. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog