From: "Kirill A. Shutemov" <kirill@shutemov.name>
To: Alexandru Moise <00moses.alexander00@gmail.com>
Cc: akpm@linux-foundation.org, mhocko@suse.com,
aneesh.kumar@linux.vnet.ibm.com, n-horiguchi@ah.jp.nec.com,
mike.kravetz@oracle.com, khandual@linux.vnet.ibm.com,
punit.agrawal@arm.com, gerald.schaefer@de.ibm.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/madvise: enable soft offline of HugeTLB pages at PUD level
Date: Fri, 29 Sep 2017 16:55:54 +0300 [thread overview]
Message-ID: <20170929135554.6cz7lpjn7gepmlf4@node.shutemov.name> (raw)
In-Reply-To: <20170913101047.GA13026@gmail.com>
On Wed, Sep 13, 2017 at 12:10:47PM +0200, Alexandru Moise wrote:
> since 94310cb we've been able to soft offline 1G hugepages at the PGD
> level, however x86_64 gigantic hugepages are at the PUD level so we
> should add an extra check to account for hstate order at PUD level.
Have you tested other cases affected by the change? It allows migration of
1G pages in general, which might be problematic.
It also makes these pages allocated with GFP_HIGHUSER_MOVABLE instead of
GFP_HIGHUSER. Any side effects there we should consider?
> I'm not sure if this also applies to 5 level page tables on x86_64
> however. Tested with 4 level pagetable.
There's nothing changed in this regard in 5-level paging mode. PUD is
still one gig and there are no new page sizes.
--
Kirill A. Shutemov
next prev parent reply other threads:[~2017-09-29 13:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-13 10:10 Alexandru Moise
2017-09-29 13:55 ` Kirill A. Shutemov [this message]
2017-09-29 14:55 ` Alexandru Moise
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170929135554.6cz7lpjn7gepmlf4@node.shutemov.name \
--to=kirill@shutemov.name \
--cc=00moses.alexander00@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=gerald.schaefer@de.ibm.com \
--cc=khandual@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mhocko@suse.com \
--cc=mike.kravetz@oracle.com \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=punit.agrawal@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®