mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andi Shyti <andi@etezian.org>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
	Andi Shyti <andi@etezian.org>,
	Andi Shyti <andi.shyti@samsung.com>,
	Michael Hennerich <michael.hennerich@analog.com>
Subject: [PATCH 01/12] Input: ad7897 - use managed devm_device_add_group
Date: Sat, 30 Sep 2017 05:38:28 +0900	[thread overview]
Message-ID: <20170929203839.7010-2-andi@etezian.org> (raw)
In-Reply-To: <20170929203839.7010-1-andi@etezian.org>

Commit 57b8ff070f98 ("driver core: add devm_device_add_group()
and friends") has added the the managed version for creating
sysfs group files.

Use devm_device_add_group instead of sysfs_create_group and
remove the relative sysfs_remove_group and goto label.

CC: Michael Hennerich <michael.hennerich@analog.com>
Signed-off-by: Andi Shyti <andi@etezian.org>
---
 drivers/input/touchscreen/ad7877.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/drivers/input/touchscreen/ad7877.c b/drivers/input/touchscreen/ad7877.c
index 9c250ae780d9..677ba38b4d1c 100644
--- a/drivers/input/touchscreen/ad7877.c
+++ b/drivers/input/touchscreen/ad7877.c
@@ -783,18 +783,16 @@ static int ad7877_probe(struct spi_device *spi)
 		goto err_free_mem;
 	}
 
-	err = sysfs_create_group(&spi->dev.kobj, &ad7877_attr_group);
+	err = devm_device_add_group(&spi->dev, &ad7877_attr_group);
 	if (err)
 		goto err_free_irq;
 
 	err = input_register_device(input_dev);
 	if (err)
-		goto err_remove_attr_group;
+		goto err_free_irq;
 
 	return 0;
 
-err_remove_attr_group:
-	sysfs_remove_group(&spi->dev.kobj, &ad7877_attr_group);
 err_free_irq:
 	free_irq(spi->irq, ts);
 err_free_mem:
@@ -807,8 +805,6 @@ static int ad7877_remove(struct spi_device *spi)
 {
 	struct ad7877 *ts = spi_get_drvdata(spi);
 
-	sysfs_remove_group(&spi->dev.kobj, &ad7877_attr_group);
-
 	ad7877_disable(ts);
 	free_irq(ts->spi->irq, ts);
 
-- 
2.14.2

  reply	other threads:[~2017-09-29 20:57 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-29 20:38 [PATCH 00/12] use managed devm_device_add_group for all touchscreen drivers Andi Shyti
2017-09-29 20:38 ` Andi Shyti [this message]
2017-09-29 23:32   ` [PATCH 01/12] Input: ad7897 - use managed devm_device_add_group Dmitry Torokhov
2017-10-27  6:11     ` Andi Shyti
2017-09-29 20:38 ` [PATCH 02/12] Input: ad7879 " Andi Shyti
2017-09-29 23:48   ` Dmitry Torokhov
2017-09-29 20:38 ` [PATCH 03/12] Input: ads7846 " Andi Shyti
2017-09-29 23:46   ` Dmitry Torokhov
2017-09-29 20:38 ` [PATCH 04/12] Input: atmel_mxt_ts " Andi Shyti
2017-09-29 23:46   ` Dmitry Torokhov
2017-09-29 20:38 ` [PATCH 05/12] Input: edt-ft5x06 " Andi Shyti
2017-09-29 23:42   ` Dmitry Torokhov
2017-09-29 20:38 ` [PATCH 06/12] Input: elants_i2c " Andi Shyti
2017-09-29 23:38   ` Dmitry Torokhov
2017-09-29 20:38 ` [PATCH 07/12] Input: ili210x " Andi Shyti
2017-09-29 23:45   ` Dmitry Torokhov
2017-09-29 20:38 ` [PATCH 08/12] Input: melfas_mip4 " Andi Shyti
2017-09-29 23:38   ` Dmitry Torokhov
2017-09-29 20:38 ` [PATCH 09/12] Input: raydium_i2c_ts " Andi Shyti
2017-09-29 23:39   ` Dmitry Torokhov
2017-09-29 20:38 ` [PATCH 10/12] Input: rohm_bu21023 " Andi Shyti
2017-09-29 23:39   ` Dmitry Torokhov
2017-09-29 20:38 ` [PATCH 11/12] Input: tsc200x-core " Andi Shyti
2017-09-29 23:44   ` Dmitry Torokhov
2017-09-29 20:38 ` [PATCH 12/12] Input: wdt87xx_i2c " Andi Shyti
2017-09-29 23:41   ` Dmitry Torokhov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170929203839.7010-2-andi@etezian.org \
    --to=andi@etezian.org \
    --cc=andi.shyti@samsung.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michael.hennerich@analog.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®