mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Tobin C. Harding" <me@tobin.cc>
To: Srishti Sharma <srishtishar@gmail.com>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
	outreachy-kernel@googlegroups.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/6] Replace container_of with list_entry
Date: Sat, 30 Sep 2017 21:11:49 +1000	[thread overview]
Message-ID: <20170930111149.GB25277@eros> (raw)
In-Reply-To: <cover.1506755265.git.srishtishar@gmail.com>

On Sat, Sep 30, 2017 at 12:49:00PM +0530, Srishti Sharma wrote:
> Replaces instances of container_of with list_entry to 
> access current list element.
> 
> Srishti Sharma (6):
>   Staging: rtl8188eu: core: Use list_entry instead of container_of
>   Staging: rtl8188eu: core: Use list_entry instead of container_of
>   Staging: rtl8188eu: core: Use list_entry instead of container_of
>   Staging: rtl8188eu: core: Use list_entry instead of container_of
>   Staging: rtl8188eu: core: Use list_entry instead of container_of
>   Staging: rtl8188eu: core: Use list_entry instead of container_of

You may have trouble getting patches merged with duplicate commit logs like this. The reason is that
the git index should be grep'able. You may like to squash all of these commits into a single patch
since they all do the same thing. The mantra is 'one thing per patch' so this makes sense in this
case.

Hope this helps,
Tobin.

  parent reply	other threads:[~2017-09-30 11:11 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-30  7:19 Srishti Sharma
2017-09-30  7:19 ` [PATCH 1/6] Staging: rtl8188eu: core: Use list_entry instead of container_of Srishti Sharma
2017-09-30  7:19 ` [PATCH 2/6] " Srishti Sharma
2017-09-30  7:20 ` [PATCH 3/6] " Srishti Sharma
2017-09-30  7:20 ` [PATCH 4/6] " Srishti Sharma
2017-09-30  7:20 ` [PATCH 5/6] " Srishti Sharma
2017-09-30  7:21 ` [PATCH 6/6] " Srishti Sharma
2017-09-30  8:31   ` [Outreachy kernel] " Julia Lawall
2017-09-30 11:11 ` Tobin C. Harding [this message]
2017-10-03 16:14 ` [PATCH 0/6] Replace container_of with list_entry Greg KH
2017-10-03 16:30   ` Srishti Sharma

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170930111149.GB25277@eros \
    --to=me@tobin.cc \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=outreachy-kernel@googlegroups.com \
    --cc=srishtishar@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®