From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751004AbdJADCx (ORCPT ); Sat, 30 Sep 2017 23:02:53 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:34040 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750842AbdJADCw (ORCPT ); Sat, 30 Sep 2017 23:02:52 -0400 Date: Sun, 01 Oct 2017 04:02:50 +0100 (WEST) Message-Id: <20171001.040250.1687037732691944138.davem@davemloft.net> To: f.fainelli@gmail.com Cc: netdev@vger.kernel.org, andrew@lunn.ch, vivien.didelot@savoirfairelinux.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next] Revert "net: dsa: bcm_sf2: Defer port enabling to calling port_enable" From: David Miller In-Reply-To: <20170928181906.3156-1-f.fainelli@gmail.com> References: <20170928181906.3156-1-f.fainelli@gmail.com> X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sat, 30 Sep 2017 20:02:52 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Florian Fainelli Date: Thu, 28 Sep 2017 11:19:06 -0700 > This reverts commit e85ec74ace29 ("net: dsa: bcm_sf2: Defer port > enabling to calling port_enable") because this now makes an unbind > followed by a bind to fail connecting to the ingrated PHY. > > What this patch missed is that we need the PHY to be enabled with > bcm_sf2_gphy_enable_set() before probing it on the MDIO bus. This is > correctly done in the ops->setup() function, but by the time > ops->port_enable() runs, this is too late. Upon unbind we would power > down the PHY, and so when we would bind again, the PHY would be left > powered off. > > Fixes: e85ec74ace29 ("net: dsa: bcm_sf2: Defer port enabling to calling port_enable") > Signed-off-by: Florian Fainelli Applied.