From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751042AbdJADNJ (ORCPT ); Sat, 30 Sep 2017 23:13:09 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:34254 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750730AbdJADNI (ORCPT ); Sat, 30 Sep 2017 23:13:08 -0400 Date: Sun, 01 Oct 2017 04:13:06 +0100 (WEST) Message-Id: <20171001.041306.1619218334938501775.davem@davemloft.net> To: colin.king@canonical.com Cc: yisen.zhuang@huawei.com, salil.mehta@huawei.com, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: hns3: fix null pointer dereference before null check From: David Miller In-Reply-To: <20170929195123.4189-1-colin.king@canonical.com> References: <20170929195123.4189-1-colin.king@canonical.com> X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sat, 30 Sep 2017 20:13:08 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Colin King Date: Fri, 29 Sep 2017 20:51:23 +0100 > From: Colin Ian King > > pointer ndev is being dereferenced with the call to netif_running > before it is being null checked. Re-order the code to only dereference > ndev after it has been null checked. > > Detected by CoverityScan, CID#1457206 ("Dereference before null check") > > Fixes: 9df8f79a4d29 ("net: hns3: Add DCB support when interacting with network stack") > Signed-off-by: Colin Ian King Applied.