From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751130AbdJBGGW (ORCPT ); Mon, 2 Oct 2017 02:06:22 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:60926 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751036AbdJBGGV (ORCPT ); Mon, 2 Oct 2017 02:06:21 -0400 Date: Sun, 01 Oct 2017 23:06:20 -0700 (PDT) Message-Id: <20171001.230620.73466517361012407.davem@davemloft.net> To: colin.king@canonical.com Cc: jiri@mellanox.com, idosch@mellanox.com, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH][next] mlxsw: spectrum: fix uninitialized value in err From: David Miller In-Reply-To: <20171001162735.8091-1-colin.king@canonical.com> References: <20171001162735.8091-1-colin.king@canonical.com> X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sun, 01 Oct 2017 23:06:20 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Colin King Date: Sun, 1 Oct 2017 17:27:35 +0100 > From: Colin Ian King > > In the unlikely event that mfc->mfc_un.res.ttls[i] is 255 for all > values of i from 0 to MAXIVS-1, the err is not set at all and hence > has a garbage value on the error return at the end of the function, > so initialize it to 0. Also, the error return check on err and goto > to err: inside the for loop makes it impossible for err to be zero > at the end of the for loop, so we can remove the redundant err check > at the end of the loop. > > Detected by CoverityScan CID#1457207 ("Unitialized scalar value") > > Fixes: c011ec1bbfd6 ("mlxsw: spectrum: Add the multicast routing offloading logic") > Signed-off-by: Colin Ian King Applied.