From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751123AbdJAK6U (ORCPT ); Sun, 1 Oct 2017 06:58:20 -0400 Received: from onstation.org ([52.200.56.107]:36212 "EHLO onstation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751071AbdJAK6T (ORCPT ); Sun, 1 Oct 2017 06:58:19 -0400 Date: Sun, 1 Oct 2017 06:58:17 -0400 From: Brian Masney To: Jonathan Cameron Cc: linux-iio@vger.kernel.org, gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net, linux-kernel@vger.kernel.org, Jon.Brenner@ams.com Subject: Re: [PATCH 3/3] staging: iio: tsl2x7x: migrate *_thresh_period sysfs attributes to iio_event_spec Message-ID: <20171001105817.salu4ymwgg4jrvqu@073846331c0b> References: <20170930010921.15447-1-masneyb@onstation.org> <20170930010921.15447-4-masneyb@onstation.org> <20171001111446.75f3d7cf@archlinux> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171001111446.75f3d7cf@archlinux> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Oct 01, 2017 at 11:14:46AM +0100, Jonathan Cameron wrote: > On Fri, 29 Sep 2017 21:09:21 -0400 > Brian Masney wrote: > > > The sysfs attributes in_intensity0_thresh_period and > > in_proximity0_thresh_period are currently directly created by the driver. > > This patch migrates the creation of these sysfs attributes from the driver > > to using the IIO core via iio_event_spec. > > > > Signed-off-by: Brian Masney > > One question down the end about whether we should be using IIO_EV_DIR_EITHER > rather than IIO_EV_DIR_NONE > > NONE is only really for thing where a direction makes not sense rather > than to remove the direction be specified for a particular element. > > Otherwise looks good. I'd just have changed this, but wasn't sure if > there was deeper logic behind your choice that I was missing! There wasn't any deeper logic to this. :) I'll test it with IIO_EV_DIR_EITHER and send v2 with my next batch of cleanups unless you change it before then. Thanks, Brian