From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751398AbdJAPNU (ORCPT ); Sun, 1 Oct 2017 11:13:20 -0400 Received: from mail.kernel.org ([198.145.29.99]:34790 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751093AbdJAPNT (ORCPT ); Sun, 1 Oct 2017 11:13:19 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5BDD1218D6 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=sre@kernel.org Date: Sun, 1 Oct 2017 17:13:16 +0200 From: Sebastian Reichel To: Arvind Yadav Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH] HSI: hsi_char: pr_err() strings should end with newlines Message-ID: <20171001151316.mklrwif4tg5nx5ok@earth> References: <74daad7cb1d5507d4531b5ac82d5002834156ced.1506406503.git.arvind.yadav.cs@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="5ckpcrsdrwndaf74" Content-Disposition: inline In-Reply-To: <74daad7cb1d5507d4531b5ac82d5002834156ced.1506406503.git.arvind.yadav.cs@gmail.com> User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --5ckpcrsdrwndaf74 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Tue, Sep 26, 2017 at 11:46:14AM +0530, Arvind Yadav wrote: > pr_err() messages should end with a new-line to avoid other messages > being concatenated. >=20 > Signed-off-by: Arvind Yadav Thanks, queued. -- Sebastian > --- > drivers/hsi/clients/hsi_char.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/drivers/hsi/clients/hsi_char.c b/drivers/hsi/clients/hsi_cha= r.c > index 57f70c2..cf9c2a3 100644 > --- a/drivers/hsi/clients/hsi_char.c > +++ b/drivers/hsi/clients/hsi_char.c > @@ -773,13 +773,13 @@ static int __init hsc_init(void) > =20 > if ((max_data_size < 4) || (max_data_size > 0x10000) || > (max_data_size & (max_data_size - 1))) { > - pr_err("Invalid max read/write data size"); > + pr_err("Invalid max read/write data size\n"); > return -EINVAL; > } > =20 > ret =3D hsi_register_client_driver(&hsc_driver); > if (ret) { > - pr_err("Error while registering HSI/SSI driver %d", ret); > + pr_err("Error while registering HSI/SSI driver %d\n", ret); > return ret; > } > =20 > --=20 > 1.9.1 >=20 --5ckpcrsdrwndaf74 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEE72YNB0Y/i3JqeVQT2O7X88g7+poFAlnRBgwACgkQ2O7X88g7 +poUPw//X/vu8xqWO5zS3hJ/goenlz9YP9wkvYH2MgqwFSDGv4beO6GirTRD4InV w4KFCSHENqb5SWD030GxIxThlI+aFJYwbfPnJ84xi3rttpJDRdyiiKWUnaarmtJZ srXmUQfs3H68G2tVUai16XOQL7mqCw1crdYaj9dGk4IQIWUeQLaNgPFAvJ3inNf6 U8EIiliynperuL3c5/wRZH8rFnBhz+YGsOXL8iK/qA4TU3TvldEZbMWHHS0vTxXg XAJ7ogGUro6ktryN6l+5/XYlpgRCGJBMlFbLzfiB6RSW+54vQ3GlDKMKKiOo5gpq hZ9ceI3jTWFX6b2nZ2JgxEDKFy4Z6btZ3kI7rhAwDlKFwuDOQWrqx2MjptUTDaX3 ha8ZoH4RoFkYftUh12DepsTqr5BujMpg94jmqvPHzVQItEOLohQGo0PzqqA48/dO 4nZasIMgPT5Fs6YyM1CRqprohm3uvUDi7qssKwwzMdU4Xbv8VgcVqdeKm6InnJij QfkxHV5HYUbqmA5Mb7hIyLSnbV9fjALCcqQyUF38CfDU3wmALs9vdZLpysI91m0c H274HIjpp3IpbMhZqh+IHzLN7diCTDUXdSi4+S4RMQtufDeR4G/G2ZnEiKZNNBjQ 8JnXD8YlpunocAYNP3W5FGMCfPwUdrwI3kAe1h63GiAURfqS65A= =Z1k/ -----END PGP SIGNATURE----- --5ckpcrsdrwndaf74--