From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751408AbdJBXEs (ORCPT ); Mon, 2 Oct 2017 19:04:48 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:52756 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751084AbdJBXEq (ORCPT ); Mon, 2 Oct 2017 19:04:46 -0400 Date: Mon, 02 Oct 2017 16:04:45 -0700 (PDT) Message-Id: <20171002.160445.737065995396076298.davem@davemloft.net> To: madalin.bucur@nxp.com Cc: netdev@vger.kernel.org, f.fainelli@gmail.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] fsl/fman: remove of_node From: David Miller In-Reply-To: <1506940297-20442-1-git-send-email-madalin.bucur@nxp.com> References: <1506940297-20442-1-git-send-email-madalin.bucur@nxp.com> X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 02 Oct 2017 16:04:46 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Madalin Bucur Date: Mon, 2 Oct 2017 13:31:37 +0300 > The FMan MAC driver allocates a platform device for the Ethernet > driver to probe on. Setting pdev->dev.of_node with the MAC node > triggers the MAC driver probing of the new platform device. While > this fails quickly and does not affect the functionality of the > drivers, it is incorrect and must be removed. This was added to > address a report that DSA code using of_find_net_device_by_node() > is unable to use the DPAA interfaces. Error message seen before > this fix: > > fsl_mac dpaa-ethernet.0: __devm_request_mem_region(mac) failed > fsl_mac: probe of dpaa-ethernet.0 failed with error -16 > > Signed-off-by: Madalin Bucur Is the DSA issue no longer something we need to be concerned about? If not, why? You have to explain this.