From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751133AbdJBHvI (ORCPT ); Mon, 2 Oct 2017 03:51:08 -0400 Received: from mail-wm0-f65.google.com ([74.125.82.65]:35238 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750944AbdJBHvG (ORCPT ); Mon, 2 Oct 2017 03:51:06 -0400 X-Google-Smtp-Source: AOwi7QD5AizHYF3pJsOaUv0x+zCZ0Z6M+bYqPxa+dJDHGgTh3CoPwa79Ffs9silff61R57yIpTMpvw== Date: Mon, 2 Oct 2017 09:51:02 +0200 From: Daniel Vetter To: Philippe CORNU Cc: Benjamin Gaignard , "architt@codeaurora.org" , "a.hajda@samsung.com" , "Laurent.pinchart@ideasonboard.com" , "airlied@linux.ie" , "daniel.vetter@intel.com" , "jani.nikula@linux.intel.com" , "seanpaul@chromium.org" , Yannick FERTRE , "linux-kernel@vger.kernel.org" , "dri-devel@lists.freedesktop.org" Subject: Re: [PATCH 0/3] Simplify panel bridge cleanup Message-ID: <20171002075102.zrn7rvl6k4kpg2d6@phenom.ffwll.local> Mail-Followup-To: Philippe CORNU , Benjamin Gaignard , "architt@codeaurora.org" , "a.hajda@samsung.com" , "Laurent.pinchart@ideasonboard.com" , "airlied@linux.ie" , "daniel.vetter@intel.com" , "jani.nikula@linux.intel.com" , "seanpaul@chromium.org" , Yannick FERTRE , "linux-kernel@vger.kernel.org" , "dri-devel@lists.freedesktop.org" References: <1506689959-7858-1-git-send-email-benjamin.gaignard@linaro.org> <52057df2-c7bd-cdc8-9fee-d4b8b1b5acf8@st.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <52057df2-c7bd-cdc8-9fee-d4b8b1b5acf8@st.com> X-Operating-System: Linux phenom 4.12.0-1-amd64 User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 29, 2017 at 03:03:54PM +0000, Philippe CORNU wrote: > Hi Benjamin, > and many thanks for this cleanup patchset. > > Reviewed-by: Philippe Cornu > Tested-by: Philippe Cornu Can you pls either convert vc4 and dw-mipi too, or add an entry to our todo list in Documentation/gpu/todo.rst? Thanks, Daniel > > Philippe :-) > > On 09/29/2017 02:59 PM, Benjamin Gaignard wrote: > > The goal of this series is to simplify driver code when they need to clean up > > a previously allocated panel bridge. > > Few drivers have "is_panel_bridge" flag to be able to distinguish a > > drm_panel_bridge from "simple" drm_bridge. > > To remove this flag I propose to > > - let drm_panel_bridge_remove() check if the bridge provided in parameter is > > really a drm_panel_bridge. > > - add drm_of_panel_bridge_remove() to remove a bridge given DT port and > > endpoint > > Finally that allow to remove drm_bridge structure and "is_panel_bridge" flag > > from stm driver internal structure. > > > > Benjamin Gaignard (3): > > drm/bridge: make drm_panel_bridge_remove more robust > > drm/drm_of: add drm_of_panel_bridge_remove function > > drm/stm: ltdc: remove bridge from driver internal structure > > > > drivers/gpu/drm/bridge/panel.c | 10 +++++++++- > > drivers/gpu/drm/drm_of.c | 33 +++++++++++++++++++++++++++++++++ > > drivers/gpu/drm/stm/ltdc.c | 16 +++++----------- > > drivers/gpu/drm/stm/ltdc.h | 2 -- > > include/drm/drm_of.h | 8 ++++++++ > > 5 files changed, 55 insertions(+), 14 deletions(-) > > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch