From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751896AbdJBO4b (ORCPT <rfc822;w@1wt.eu>);
        Mon, 2 Oct 2017 10:56:31 -0400
Received: from mx2.suse.de ([195.135.220.15]:35206 "EHLO mx1.suse.de"
        rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP
        id S1751281AbdJBO4a (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 2 Oct 2017 10:56:30 -0400
Date: Mon, 2 Oct 2017 16:56:27 +0200
From: Petr Mladek <pmladek@suse.com>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
        Ingo Molnar <mingo@kernel.org>,
        Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
        Steven Rostedt <rostedt@goodmis.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] printk: simplify no_printk()
Message-ID: <20171002145627.GG8637@pathway.suse.cz>
References: <1505660504-11059-1-git-send-email-yamada.masahiro@socionext.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1505660504-11059-1-git-send-email-yamada.masahiro@socionext.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon 2017-09-18 00:01:44, Masahiro Yamada wrote:
> Commit 069f0cd00df0 ("printk: Make the printk*once() variants return
> a value") surrounded the macro implementation with ({ ... }).
> 
> Now, the inner do { ... } while (0); is redundant.
> 
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>

Looks fine to me. The return value is slightly more visible now ;-)

Reviewed-by: Petr Mladek <pmladek@suse.com>

JFYI, I have pushed it into for-4.15 branch.

Best Regards,
Petr