From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751770AbdJBPhY (ORCPT ); Mon, 2 Oct 2017 11:37:24 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:35706 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751061AbdJBPhX (ORCPT ); Mon, 2 Oct 2017 11:37:23 -0400 Date: Mon, 2 Oct 2017 17:37:18 +0200 From: Andrew Lunn To: Razvan Stefanescu Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, agraf@suse.de, arnd@arndb.de, alexandru.marginean@nxp.com, bogdan.purcareata@nxp.com, ruxandra.radulescu@nxp.com, laurentiu.tudor@nxp.com, stuyoder@gmail.com Subject: Re: [PATCH v2 3/6] staging: fsl-dpaa2/ethsw: Add ethtool support Message-ID: <20171002153718.GJ17713@lunn.ch> References: <1506933380-12641-1-git-send-email-razvan.stefanescu@nxp.com> <1506933380-12641-4-git-send-email-razvan.stefanescu@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1506933380-12641-4-git-send-email-razvan.stefanescu@nxp.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Razvan > +static void ethsw_get_drvinfo(struct net_device *netdev, > + struct ethtool_drvinfo *drvinfo) > +{ > + struct ethsw_port_priv *port_priv = netdev_priv(netdev); > + u16 version_major, version_minor; > + int err; > + > + strlcpy(drvinfo->driver, KBUILD_MODNAME, sizeof(drvinfo->driver)); > + strlcpy(drvinfo->version, ethsw_drv_version, sizeof(drvinfo->version)); Software driver versions are mostly useless. I would suggest you remove this. Andrew