From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751856AbdJBQYL (ORCPT <rfc822;w@1wt.eu>);
        Mon, 2 Oct 2017 12:24:11 -0400
Received: from mail.free-electrons.com ([62.4.15.54]:53506 "EHLO
        mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751127AbdJBQYJ (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 2 Oct 2017 12:24:09 -0400
Date: Mon, 2 Oct 2017 18:24:05 +0200
From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: Chen-Yu Tsai <wens@csie.org>
Cc: Lee Jones <lee.jones@linaro.org>, Mark Brown <broonie@kernel.org>,
        linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com,
        Quentin Schulz <quentin.schulz@free-electrons.com>
Subject: Re: [PATCH 5/7] ARM: dts: sun8i: a83t: cubietruck-plus: Add AXP818
 regulator nodes
Message-ID: <20171002162405.jndvig3fxuj6d3ce@flea>
References: <20170929032514.31727-1-wens@csie.org>
 <20170929032514.31727-6-wens@csie.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
        protocol="application/pgp-signature"; boundary="vuqobhb44zje7puz"
Content-Disposition: inline
In-Reply-To: <20170929032514.31727-6-wens@csie.org>
User-Agent: NeoMutt/20170914 (1.9.0)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


--vuqobhb44zje7puz
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi,

On Fri, Sep 29, 2017 at 03:25:12AM +0000, Chen-Yu Tsai wrote:
> +#include "axp81x.dtsi"
> +
> +&reg_aldo1 {
> +	regulator-always-on;
> +	regulator-min-microvolt =3D <1800000>;
> +	regulator-max-microvolt =3D <1800000>;
> +	regulator-name =3D "vcc18-csi2-dsi-efuse-hdmi-d4dp";
> +};

I'm not really fond of these names. It's easy to miss some components
(especially since we most of the time don't have the schematics), and
if it's not complete, the obscure name isn't worth it either.

What about vcc-1.8 for this one ?

> +&reg_aldo2 {
> +	regulator-always-on;
> +	regulator-min-microvolt =3D <1800000>;
> +	regulator-max-microvolt =3D <1800000>;
> +	regulator-name =3D "vdd-drampll-vcc18-pll-adc-cpvdd-ldoin";
> +};

dram-pll?

> +&reg_aldo3 {
> +	regulator-always-on;
> +	regulator-min-microvolt =3D <3000000>;
> +	regulator-max-microvolt =3D <3000000>;
> +	regulator-name =3D "vcc-pl-avcc";
> +};

avcc?

etc..

>  	status =3D "disabled";
>  };
> =20
> +&reg_vcc3v3 {
> +	status =3D "disabled";
> +};
> +
>  &reg_vcc5v0 {
>  	status =3D "disabled";
>  };

Why not simply remove the DTSI then?

Maxime

--=20
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

--vuqobhb44zje7puz
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIcBAEBAgAGBQJZ0mglAAoJEBx+YmzsjxAgX7gQALPm1HSkqxE3dZbziH48L1Om
nBNBGSoXHgy+++W0E6jNBFnlXgrmKK8zewN1g8xlqAzAkMrTRDyag4WUOxK6I/tn
EYGT5HGblJO9cSz5wmh7728sE2t48iNdF5FtPNy13jEkxAAAq9ePFn0zuADrpc1x
cqTFZxcgpuFgSGWckgVHuLtswaUFXBR77/INf/Fs87q7N9vNgoQTsv9SuGPmXrkT
qxgrbkzeYXVDi9IKA+nQHRmnGuph2ymukF65UTedYF8b++n7Gnh1baaOZH7hUlZs
oP2qeAimzRDdwpsYotstrYYeWoLVh1aJ2n8ftjojYwQHKRp2HyHC6YCJpI3nI3Te
nF4DRzdi+bQfOeH23MfI4XgH43LRapUfj+F28CuFxjKD/5bZZ5VtlTA2YiQZYhgS
voq0Edg9Bkk89kjOtFFxZ5pqmObbMqEf2l5xNxLjkhZGchTMVtlHv9oWkfU90nJT
dpqen89JT2K281CnArkFzNnbSbzUWtkGBFwNg8HoDUMLEYONk1u9vowUiRxxjQFu
O8LJHWqhChAhpbFcEPGnZ5AlKYqQ+iI7xhAwteT+RD/POkruyszU7b6EM4LdpnQ5
UT8grPCkE4UvDhL3cMi/fGbCuEJ2vRcPbbaznp1+q3d9XuDQvMPXRBYb6NefDzS8
6cYYkYVZx/ueuBd2Z6R9
=g6dE
-----END PGP SIGNATURE-----

--vuqobhb44zje7puz--