From: Bjorn Helgaas <helgaas@kernel.org>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
Linux PCI <linux-pci@vger.kernel.org>,
Linux PM <linux-pm@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Subject: Re: [PATCH] PCI / PM: Add dev_dbg() to print device suspend power states
Date: Mon, 2 Oct 2017 18:29:41 -0500 [thread overview]
Message-ID: <20171002232941.GF5407@bhelgaas-glaptop.roam.corp.google.com> (raw)
In-Reply-To: <8776535.A6PtrVU7Ea@aspire.rjw.lan>
On Sat, Sep 30, 2017 at 01:31:15AM +0200, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>
> It sometimes is useful to know what power states the kernel thinks
> it puts PCI devices into during system suspend, so add a dev_dbg()
> statement for that.
>
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Acked-by: Bjorn Helgaas <bhelgaas@google.com>
I think you have other pending changes in this path, so can you take
this one as well?
> ---
> drivers/pci/pci-driver.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> Index: linux-pm/drivers/pci/pci-driver.c
> ===================================================================
> --- linux-pm.orig/drivers/pci/pci-driver.c
> +++ linux-pm/drivers/pci/pci-driver.c
> @@ -798,6 +798,9 @@ static int pci_pm_suspend_noirq(struct d
> pci_prepare_to_sleep(pci_dev);
> }
>
> + dev_dbg(dev, "PCI PM: Suspend power state: %s\n",
> + pci_power_name(pci_dev->current_state));
> +
> pci_pm_set_unknown_state(pci_dev);
>
> /*
>
next prev parent reply other threads:[~2017-10-02 23:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-29 23:31 Rafael J. Wysocki
2017-10-02 23:29 ` Bjorn Helgaas [this message]
2017-10-02 23:45 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171002232941.GF5407@bhelgaas-glaptop.roam.corp.google.com \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=srinivas.pandruvada@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®