From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751501AbdJCRU2 (ORCPT ); Tue, 3 Oct 2017 13:20:28 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:47488 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751090AbdJCRUZ (ORCPT ); Tue, 3 Oct 2017 13:20:25 -0400 Date: Tue, 03 Oct 2017 10:20:24 -0700 (PDT) Message-Id: <20171003.102024.1382587331164513041.davem@davemloft.net> To: colin.king@canonical.com Cc: andrew@lunn.ch, vivien.didelot@savoirfairelinux.com, f.fainelli@gmail.com, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: dsa: lan9303: make functions lan9303_mdio_phy_{read|write} static From: David Miller In-Reply-To: <20171003103918.26934-1-colin.king@canonical.com> References: <20171003103918.26934-1-colin.king@canonical.com> X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 03 Oct 2017 10:20:25 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Colin King Date: Tue, 3 Oct 2017 11:39:18 +0100 > From: Colin Ian King > > The functions lan9303_mdio_phy_write and lan9303_mdio_phy_read are local > to the source and do not need to be in global scope, so make them static. > > Cleans up sparse warnings: > symbol 'lan9303_mdio_phy_write' was not declared. Should it be static? > symbol 'lan9303_mdio_phy_read' was not declared. Should it be static? > > Signed-off-by: Colin Ian King Applied.