From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751344AbdJDEn7 (ORCPT ); Wed, 4 Oct 2017 00:43:59 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:33160 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750871AbdJDEn6 (ORCPT ); Wed, 4 Oct 2017 00:43:58 -0400 Date: Tue, 03 Oct 2017 21:43:57 -0700 (PDT) Message-Id: <20171003.214357.2276688669726195045.davem@davemloft.net> To: madalin.bucur@nxp.com Cc: netdev@vger.kernel.org, andrew@lunn.ch, f.fainelli@gmail.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] fsl/fman: remove of_node From: David Miller In-Reply-To: References: <1506940297-20442-1-git-send-email-madalin.bucur@nxp.com> <20171002.160445.737065995396076298.davem@davemloft.net> X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 03 Oct 2017 21:43:57 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Madalin-cristian Bucur Date: Tue, 3 Oct 2017 08:49:31 +0000 > My patch removes the of_node that was set to a device that was not an > of_device, preventing duplicated probing of both the real of_device > and the "fake" one created through this assignment. > > I understand that the DSA issue that triggered the initial change > was related to DSA finding the network devices using > of_find_net_device_by_node(), something that will not work for the > DPAA case where the netdevice does not have an of_node. I do not know > enough about DSA to come up with a solution for this problem now. > Andrew, Florian, can you please comment on this? It sounds like you're knowingly breaking DSA.