From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751514AbdJCFWW (ORCPT ); Tue, 3 Oct 2017 01:22:22 -0400 Received: from fllnx209.ext.ti.com ([198.47.19.16]:12672 "EHLO fllnx209.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751132AbdJCFWT (ORCPT ); Tue, 3 Oct 2017 01:22:19 -0400 From: Vignesh R To: Marek Vasut , Cyrille Pitchen CC: David Woodhouse , Brian Norris , Boris Brezillon , Rob Herring , , , , Vignesh R , linux-arm-kernel Subject: [PATCH v4 5/6] mtd: spi-nor: cadence-quadspi: Fix error path in probe Date: Tue, 3 Oct 2017 10:49:24 +0530 Message-ID: <20171003051925.8821-6-vigneshr@ti.com> X-Mailer: git-send-email 2.14.2 In-Reply-To: <20171003051925.8821-1-vigneshr@ti.com> References: <20171003051925.8821-1-vigneshr@ti.com> MIME-Version: 1.0 Content-Type: text/plain X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fix the reversed goto labels, so that we disable cqspi controller only if its enabled previously. This is a minor cleanup. Signed-off-by: Vignesh R --- drivers/mtd/spi-nor/cadence-quadspi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/mtd/spi-nor/cadence-quadspi.c b/drivers/mtd/spi-nor/cadence-quadspi.c index d9629e8f4798..60b557e00cfb 100644 --- a/drivers/mtd/spi-nor/cadence-quadspi.c +++ b/drivers/mtd/spi-nor/cadence-quadspi.c @@ -1255,9 +1255,9 @@ static int cqspi_probe(struct platform_device *pdev) } return ret; -probe_irq_failed: - cqspi_controller_enable(cqspi, 0); probe_setup_failed: + cqspi_controller_enable(cqspi, 0); +probe_irq_failed: clk_disable_unprepare(cqspi->clk); return ret; } -- 2.14.1